CONFIG: Update the solution to .net and all Nuget packages to latest stable versions#536
Open
perirrs wants to merge 45 commits into
Open
CONFIG: Update the solution to .net and all Nuget packages to latest stable versions#536perirrs wants to merge 45 commits into
perirrs wants to merge 45 commits into
Conversation
…K 2.0.1 to 2.0.7 required for net10 support)
…from 9.0.3 to 10.0.8
…and .OAuth from 2.3.0 to 2.3.10 (coupled version set)
…s from 6.6.1 to 6.8.1
…es from 5.5.1 to 5.5.4
…uild.yml for net10 CI
…ransitive 8.0.0 from EF Tools (fixes dotnet ef design-time TypeLoadException in CI Deploy Database)
There was a problem hiding this comment.
Pull request overview
This PR upgrades the solution’s target framework and dependency stack to newer .NET/NuGet versions, and updates test infrastructure to keep integration/acceptance tests working with the updated runtime and server configuration.
Changes:
- Move projects from
net9.0tonet10.0, and update GitHub Actions to usedotnet 10.0.100. - Bump multiple NuGet dependencies (ASP.NET Core, EF Core, Azure SDKs, test tooling like coverlet/xUnit runner).
- Update test brokers/factories and assertions (auth test handler, Azure Blob config overrides, no-op notification provider, audit/OdsData test adjustments).
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| ISL.ReIdentification.WebApps.Portals/ISL.ReIdentification.Portals.Server/ISL.ReIdentification.Portals.Server.csproj | Targets net10.0, updates ASP.NET Core-related packages. |
| ISL.ReIdentification.WebApps.Portals/ISL.ReIdentification.Portals.Server.Tests.Unit/ISL.ReIdentification.Portals.Server.Tests.Unit.csproj | Targets net10.0, updates test dependencies. |
| ISL.ReIdentification.WebApps.Portals/ISL.ReIdentification.Portals.Server.Tests.Integration/ISL.ReIdentification.Portals.Server.Tests.Integration.csproj | Targets net10.0, updates integration test dependencies. |
| ISL.ReIdentification.WebApps.Portals/ISL.ReIdentification.Portals.Server.Tests.Acceptance/ISL.ReIdentification.Portals.Server.Tests.Acceptance.csproj | Targets net10.0, updates acceptance test deps and adds AzureBlobStorage provider package. |
| ISL.ReIdentification.WebApps.Portals/ISL.ReIdentification.Portals.Server.Tests.Acceptance/Brokers/TestWebApplicationFactory.cs | Extends acceptance host overrides (security + blob storage configs + notification provider). |
| ISL.ReIdentification.WebApps.Portals/ISL.ReIdentification.Portals.Server.Tests.Acceptance/Brokers/NoOpNotificationProvider.cs | Adds no-op notification provider for acceptance tests. |
| ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Server/ISL.ReIdentification.Configurations.Server.csproj | Targets net10.0, updates server package references. |
| ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Server.Tests.Unit/ISL.ReIdentification.Configurations.Server.Tests.Unit.csproj | Targets net10.0, updates unit test dependencies. |
| ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Server.Tests.Integration/TestAuthHandler.cs | Adds new integration auth handler for test scheme. |
| ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Server.Tests.Integration/ISL.ReIdentification.Configurations.Server.Tests.Integration.csproj | Targets net10.0, updates integration test dependencies. |
| ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Server.Tests.Integration/CustomAuthenticationSchemeOptions.cs | Adds custom auth scheme options for integration tests. |
| ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Server.Tests.Integration/Brokers/TestWebApplicationFactory.cs | Introduces integration test web app factory with auth/provider overrides. |
| ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Server.Tests.Integration/Brokers/ApiBroker.cs | Uses the new test factory and applies InvisibleApiKey headers when present. |
| ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Server.Tests.Integration/Apis/OdsData/OdsDataApiTests.GetDescendants.cs | Adjusts descendants assertion behavior. |
| ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Server.Tests.Integration/Apis/OdsData/OdsDataApiTests.Get.cs | Changes retrieval validation to query by id via filter per created record. |
| ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Server.Tests.Integration/Apis/Audits/AuditApiTests.cs | Updates audit test expectations to account for server-populated audit fields. |
| ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Server.Tests.Acceptance/ISL.ReIdentification.Configurations.Server.Tests.Acceptance.csproj | Targets net10.0, updates acceptance test dependencies. |
| ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Server.Tests.Acceptance/Apis/AuditsApiTests.Logic.cs | Updates acceptance audit tests for server-populated audit fields. |
| ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Server.Tests.Acceptance/Apis/AuditsApiTests.cs | Updates shared acceptance audit test helper for server-populated audit fields. |
| ISL.ReIdentification.Infrastructure/Program.cs | Updates generated scripts to use dotnet 10.0.100. |
| ISL.ReIdentification.Infrastructure/ISL.ReIdentification.Infrastructure.csproj | Targets net10.0, bumps dependencies. |
| ISL.ReIdentification.Functions/ISL.ReIdentification.Functions.csproj | Targets net10.0, bumps Azure Functions/Azure SDK/EF Core dependencies. |
| ISL.ReIdentification.Core/ISL.ReIdentification.Core.csproj | Targets net10.0, bumps EF Core + related packages and adds EFCore.Design reference. |
| ISL.ReIdentification.Core.Tests.Unit/Services/Foundations/Lookups/LookupServiceTests.Logic.ApplyModifyAudit.cs | Adjusts mock setup to call base implementation. |
| ISL.ReIdentification.Core.Tests.Unit/Services/Foundations/Audit/AuditsTests.Validations.Add.cs | Updates validation test expectations to match current validation rules. |
| ISL.ReIdentification.Core.Tests.Unit/ISL.ReIdentification.Core.Tests.Unit.csproj | Targets net10.0, updates unit test dependencies. |
| .github/workflows/build.yml | Uses dotnet 10.0.100 in CI. |
…hHandler, fix TestSurname typo, nullable InvisibleApiKey, rename OdsData get-each test to match behavior
…e (Linux dev-certs trust exit 4) - Add GenerateJavascriptLintingScript to ScriptGenerationService so linter.yml can be produced by the generator (ADotNet) instead of being hand-maintained. - Add Models/GithubTasks/WorkingDirectoryTask (GithubTask + working-directory) because ADotNet 4.3.0 has no model for step-level working-directory; setup-node uses the base GithubTask Uses/With. - The generated cert step runs "dotnet dev-certs https --verbose --trust || true" so the Linux runner's exit code 4 (OpenSSL trust cannot complete) no longer fails the job, while the certificate is still created. - Job SDK set to 10.0.100, consistent with the net10 uplift. The regenerated linter.yml is intentionally NOT included here; run the Infrastructure project to produce it when ready.
…it 4 Generated output of GenerateJavascriptLintingScript. The Install certificates step now runs "dotnet dev-certs https --verbose --trust || true" so the Linux runner's exit code 4 (OpenSSL trust cannot complete) no longer fails the Javascript Linting job. SDK aligned to 10.0.100 with the net10 uplift.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+11
to
+48
| lint: | ||
| name: Linting | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Install NodeJS | ||
| uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: 22 | ||
| - name: Install .Net | ||
| uses: actions/setup-dotnet@v3 | ||
| with: | ||
| dotnet-version: 10.0.100 | ||
| - uses: actions/checkout@v2 | ||
| - name: Install certificates | ||
| run: dotnet dev-certs https --verbose --trust || true | ||
| - name: Install node modules (Configuration) | ||
| working-directory: ./ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Client | ||
| run: npm install | ||
| - name: Run ESLint (Configuration) | ||
| working-directory: ./ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Client | ||
| run: npm run lint | ||
| - name: Run JS Test (Configuration) | ||
| working-directory: ./ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Client | ||
| run: npm run test | ||
| - name: Run JS Build (Configuration) | ||
| working-directory: ./ISL.ReIdentification.WebApps.Configurations/ISL.ReIdentification.Configurations.Client | ||
| run: npm run build | ||
| - name: Install node modules (Portal) | ||
| working-directory: ./ISL.ReIdentification.WebApps.Portals/ISL.ReIdentification.Portals.Client | ||
| run: npm install | ||
| - name: Run ESLint (Portal) | ||
| working-directory: ./ISL.ReIdentification.WebApps.Portals/ISL.ReIdentification.Portals.Client | ||
| run: npm run lint | ||
| - name: Run JS Test (Portal) | ||
| working-directory: ./ISL.ReIdentification.WebApps.Portals/ISL.ReIdentification.Portals.Client | ||
| run: npm run test | ||
| - name: Run JS Build (Portal) | ||
| working-directory: ./ISL.ReIdentification.WebApps.Portals/ISL.ReIdentification.Portals.Client |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes AB#29210
closes AB#29212
closes AB#29214
closes AB#29216
closes AB#29218
closes AB#29220
closes AB#29209
closes AB#29211
closes AB#29213
closes AB#29215
closes AB#29217
closes AB#29219