Fix EDInitMod.F90 initialisation of drought deciduous variables#1050
Merged
Conversation
Two local variables were not initialised before the first time being used (thanks @adrifoster for spotting it!). This PR fixes it.
I forgot to delete the assignment of the local variables when I moved it to the beginning of the `do` loop (thanks @glemieux).
glemieux
approved these changes
Jul 7, 2023
Contributor
|
Testing is underway. |
Contributor
|
Regression testing on cheyenne and izumi against Cheyenne: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two local variables were not initialised before the first time being used.
Description:
During the merge of PR #958 and the mainline, many lines of code had changed the order, and this caused
fnrt_drop_fractionandstem_drop_fractionto be used before they were initialised. Thanks @adrifoster for spotting it!Collaborators:
@adrifoster @glemieux
Expectation of Answer Changes:
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: