Skip to content

address radiation balance log messaging #772

@rgknox

Description

@rgknox

The radiation scattering code has a good number of logging messages that could use some cleaning up.

https://github.com/NGEET/fates/blob/master/biogeophys/EDSurfaceAlbedoMod.F90

There are several locations in the radiation scattering code where we print out messages when unusual behavior occurs, some of this is due to radiation budget error, and some due to other thins like unexpected canopy closure tolerances:

https://github.com/NGEET/fates/blob/master/biogeophys/EDSurfaceAlbedoMod.F90#L337
https://github.com/NGEET/fates/blob/master/biogeophys/EDSurfaceAlbedoMod.F90#L340
https://github.com/NGEET/fates/blob/master/biogeophys/EDSurfaceAlbedoMod.F90#L395-L396
https://github.com/NGEET/fates/blob/master/biogeophys/EDSurfaceAlbedoMod.F90#L920-L929
https://github.com/NGEET/fates/blob/master/biogeophys/EDSurfaceAlbedoMod.F90#L933-L938
https://github.com/NGEET/fates/blob/master/biogeophys/EDSurfaceAlbedoMod.F90#L973-L985
https://github.com/NGEET/fates/blob/master/biogeophys/EDSurfaceAlbedoMod.F90#L992-L1008
https://github.com/NGEET/fates/blob/master/biogeophys/EDSurfaceAlbedoMod.F90#L1018-L1020

PR #750 brings a diagnostic on radiation solve error. See new field in history here:

https://github.com/NGEET/fates/pull/750/files#diff-03feca0f1df8d3791c0d8f7b6055a0368d5241716d19d6a97c3d227fd6c5ad23R4923-R4926

There are a few things we can do.

  1. place in a "debug" logical
  2. modify the threshold and apply an endrun so the check only triggers when it is truly unacceptable, and stops the run
  3. other?

In the past we saw these balance error messages quite a bit, but with #750 and recent updates, maybe these messages aren't such a big deal.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions