Implementation of UGRID (part 2 of 2): Write#372
Merged
davidhassell merged 51 commits intoNCAS-CMS:mainfrom Apr 1, 2026
Merged
Implementation of UGRID (part 2 of 2): Write#372davidhassell merged 51 commits intoNCAS-CMS:mainfrom
davidhassell merged 51 commits intoNCAS-CMS:mainfrom
Conversation
davidhassell
added
enhancement
sadielbartholomew
requested changes
Mar 31, 2026
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
Looks great, other than one bit of code dodginess in netcdfread that I've highlighted in-line which needs to be updated before I'm happy to merge. Otherwise just the standard minor comments, mostly some typos/formatting issues.
Please consider my feedback and then we should be able to quickly move towards merging. Thanks.
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
sadielbartholomew
approved these changes
Apr 1, 2026
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback, especially on the main issue #372 (comment). I have done a final sanity check and everything looks good so please merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #271
Requires #371 (which has now been merged into main)