Merged
Conversation
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
sadielbartholomew
approved these changes
Jul 24, 2024
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
Thanks for addressing all of my feedback. I've done a final sanity check and it is all good. Great stuff, please merge!
Contributor
Author
|
Thanks again for your customary careful and detailed review - merging now .... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #285 and #286
h5netcdf, which also allows files in S3-compatible storage to be read.netcdf_flattenerin-house, rather than with an import. The new flattener can flatten files opened withh5netcdf, can flatten all CF references, and is more extensible to future CF references.netcdf_indexer(based onnetCDF4functionality) that allows orthogonal indexing onh5netcdfvariables.