Skip to content

Anon bucket#314

Merged
valeriupredoi merged 10 commits intomainfrom
anon_bucket
Apr 9, 2026
Merged

Anon bucket#314
valeriupredoi merged 10 commits intomainfrom
anon_bucket

Conversation

@valeriupredoi
Copy link
Copy Markdown
Collaborator

@valeriupredoi valeriupredoi commented Mar 18, 2026

Description

Closes #291

Changes in Client to emit data for Anon bucket. @maxstack it currently doesn't work from Reductionist's end, Reductionist throws a 401, could you have a look pls mate 🍺 - the test to look at is tests/test_real_s3.py::test_anon_s3 see the failed test here https://github.com/NCAS-CMS/PyActiveStorage/actions/runs/23255142731/job/67607820849?pr=314

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

@valeriupredoi valeriupredoi requested a review from maxstack March 18, 2026 16:20
@valeriupredoi valeriupredoi self-assigned this Mar 18, 2026
@valeriupredoi valeriupredoi added the enhancement New feature or request label Mar 18, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.05%. Comparing base (4beb94b) to head (dd24476).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
activestorage/reductionist.py 72.72% 3 Missing ⚠️
activestorage/active.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
- Coverage   93.59%   93.05%   -0.54%     
==========================================
  Files           7        7              
  Lines         671      677       +6     
==========================================
+ Hits          628      630       +2     
- Misses         43       47       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

 - Reductionist will only report 500 internal server errors - here we check JSON body
 - Any other error response we check text of body - this way we catch the likes of HAProxy connection limits
@valeriupredoi valeriupredoi merged commit 166d0b4 into main Apr 9, 2026
3 of 4 checks passed
@valeriupredoi valeriupredoi deleted the anon_bucket branch April 9, 2026 14:04
@valeriupredoi
Copy link
Copy Markdown
Collaborator Author

superb work @maxstack I just added a couple more tests for the anon=True case, and all is fine, very many thanks 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Anon bucket still unreachable

2 participants