Repository navigation
fix(web): name the failed action in the conversation error banner - #1808
Merged
Merged
Conversation
A thread record kept load, send, and turn failures in one error field, and the banner labeled all of them "Could not refresh conversation". A failed turn showed its error twice: inline, and again as a refresh failure. A rejected send was mislabeled the same way. Each writer now records an error source. Turn errors stay in the transcript only, send failures read "Could not send message", and the full-stage error state is reserved for load failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a turn failed, its error appeared twice. It appeared inline in the transcript and again in a red banner reading "Could not refresh conversation: …". A rejected send got the same misleading refresh label.
The thread record kept load, send, and turn failures in one
errorfield, and the banner labeled them all as refresh failures. Each writer now records anerrorSource:The CLI-not-found banner and the legacy timeline still read the same
errorfield, so they don't change.Verified in a production web build against the worktree runtime by failing a Claude Opus 5.5 turn on SDK 0.3.212. Before, the inline error and the refresh banner both showed. After, only the inline error and "Turn failed" show. New ChatView tests fail before the fix and pass after. 84 store and conversation test files pass, and web typecheck and repo lint pass.
Why
A turn failure presented as a broken conversation, which points users at the wrong problem.
UI Changes
After: the failed turn shows only its inline error.
Review Notes
An error with no recorded source keeps the old refresh wording, which matches every unlabeled writer before this change.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.