The Git-based patchers seem to be running through GetDefaultRun() most of the time, which hasn't implemented the new SplitIfMaxMastersExceeded when creating RunSynthesisMutagenPatcher here
|
return new RunSynthesisMutagenPatcher() |
|
{ |
|
DataFolderPath = dataFolder, |
|
SourcePath = null, |
|
OutputPath = Path.Combine(dataFolder, targetModKey.FileName), |
|
GameRelease = release, |
|
LoadOrderFilePath = loadOrderPath, |
|
ExtraDataFolder = Path.GetFullPath("./Data"), |
|
DefaultDataFolderPath = null, |
|
LoadOrderIncludesCreationClub = false, |
|
PatcherName = targetModKey.Name, |
|
PersistencePath = "Persistence", |
|
InternalDataFolder = LocateInternalData(fileSystem), |
|
TargetLanguage = extraParameters.TargetLanguage, |
|
Localize = extraParameters.Localize, |
|
UseUtf8ForEmbeddedStrings = extraParameters.UseUtf8ForEmbeddedStrings, |
|
FormIDRangeMode = extraParameters.FormIDRangeMode, |
|
HeaderVersionOverride = extraParameters.HeaderVersionOverride, |
|
}; |
Also, would this mean then for anyone creating patchers that they need to set the option in the TypicalOpenExtraParameters for their patchers (when it gets added)?
|
using Mutagen.Bethesda.Strings; |
|
using Synthesis.Bethesda; |
|
|
|
namespace Mutagen.Bethesda.Synthesis.Pipeline; |
|
|
|
public record TypicalOpenExtraParameters |
|
{ |
|
public Language TargetLanguage { get; init; } = Language.English; |
|
public bool Localize { get; init; } |
|
public bool UseUtf8ForEmbeddedStrings { get; init; } |
|
public float? HeaderVersionOverride { get; init; } |
|
public FormIDRangeMode FormIDRangeMode { get; init; } |
|
} |
Or am I missing a code path for git-based patchers that enables the splitting functionality?
The Git-based patchers seem to be running through
GetDefaultRun()most of the time, which hasn't implemented the newSplitIfMaxMastersExceededwhen creatingRunSynthesisMutagenPatcherhereSynthesis/Mutagen.Bethesda.Synthesis/Pipeline/SynthesisPipeline.cs
Lines 862 to 880 in d7c3788
Also, would this mean then for anyone creating patchers that they need to set the option in the TypicalOpenExtraParameters for their patchers (when it gets added)?
Synthesis/Mutagen.Bethesda.Synthesis/Pipeline/TypicalOpenExtraParameters.cs
Lines 1 to 13 in d7c3788
Or am I missing a code path for git-based patchers that enables the splitting functionality?