Skip to content

Splitting not working for Git-based patchers? #585

@mick-lue

Description

@mick-lue

The Git-based patchers seem to be running through GetDefaultRun() most of the time, which hasn't implemented the new SplitIfMaxMastersExceeded when creating RunSynthesisMutagenPatcher here

return new RunSynthesisMutagenPatcher()
{
DataFolderPath = dataFolder,
SourcePath = null,
OutputPath = Path.Combine(dataFolder, targetModKey.FileName),
GameRelease = release,
LoadOrderFilePath = loadOrderPath,
ExtraDataFolder = Path.GetFullPath("./Data"),
DefaultDataFolderPath = null,
LoadOrderIncludesCreationClub = false,
PatcherName = targetModKey.Name,
PersistencePath = "Persistence",
InternalDataFolder = LocateInternalData(fileSystem),
TargetLanguage = extraParameters.TargetLanguage,
Localize = extraParameters.Localize,
UseUtf8ForEmbeddedStrings = extraParameters.UseUtf8ForEmbeddedStrings,
FormIDRangeMode = extraParameters.FormIDRangeMode,
HeaderVersionOverride = extraParameters.HeaderVersionOverride,
};

Also, would this mean then for anyone creating patchers that they need to set the option in the TypicalOpenExtraParameters for their patchers (when it gets added)?
using Mutagen.Bethesda.Strings;
using Synthesis.Bethesda;
namespace Mutagen.Bethesda.Synthesis.Pipeline;
public record TypicalOpenExtraParameters
{
public Language TargetLanguage { get; init; } = Language.English;
public bool Localize { get; init; }
public bool UseUtf8ForEmbeddedStrings { get; init; }
public float? HeaderVersionOverride { get; init; }
public FormIDRangeMode FormIDRangeMode { get; init; }
}

Or am I missing a code path for git-based patchers that enables the splitting functionality?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions