Skip to content

New patch splitter fails on huge patches #583

@AsaNoHikari0

Description

@AsaNoHikari0

Thanks for the auto-splitting function. I've already been getting great use out of it!

But, with very large Synthesis patches, I can still get errors like this.

Finished patch.
Writing to output: %AppData%\Local\Temp\Synthesis\x0nuc3mg.pa2\Workspace\Synthesis - KID Patches\1 - KID Patcher\Synthesis - KID Patches.esp
Synthesis - KID Patches_2.esp has too many masters on masters list. 255 >= 254.
Masters:
  Skyrim.esm
  Update.esm
  Dawnguard.esm
  Dragonborn.esm
...
  Coven.esp
  mihailicecat.esp
  mihailvileguardian.esp
  Synthesis - KID Patches.esp
Mutagen.Bethesda.Plugins.Exceptions.TooManyMastersException: Synthesis - KID Patches_2.esp has too many masters on masters list. 255 >= 254.

The splitter seems to work fine for the first patch (Synthesis - KID Patches.esp), but still tries to pack too much into the second one (Synthesis - KID Patches_2.esp).

I tested this with both PR3 and PR4 and got the same result in both versions.

Context Note: I'm testing a new patcher that turns Keyword Item Distributor configs into a Synthesis patch instead of applying them on startup every time. So, it touches a lot of records. Since it creates new keywords, I expect that later split patches will need to refer to the keyword records from previous ones, which I expect will add some complexity to the splitting algorithm.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions