add /bin/ to .gitignore to comply with ant clean#9
Merged
MusicTheorist merged 3 commits intoMusicTheorist:masterfrom Jun 8, 2020
landfillbaby:master
Merged
add /bin/ to .gitignore to comply with ant clean#9MusicTheorist merged 3 commits intoMusicTheorist:masterfrom landfillbaby:master
ant clean#9MusicTheorist merged 3 commits intoMusicTheorist:masterfrom
landfillbaby:master
Conversation
MusicTheorist
added
documentation
landfillbaby
pushed a commit
that referenced
this pull request
Jul 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this way there's no duplicate files, you won't accidentally rely on them being in bin/ before building
also added a line to the dist script to include src/soundfont/sfx.sf2
to check this worked, can you run
ant clean, build and run, and see if it loads the soundfont?you might want to squash this merge