Move sounds from Engine to Particle Emitters#256
Merged
Cervator merged 3 commits intoMovingBlocks:developfrom May 3, 2018
NicholasBatesNZ:particleEmitters
Merged
Move sounds from Engine to Particle Emitters#256Cervator merged 3 commits intoMovingBlocks:developfrom NicholasBatesNZ:particleEmitters
Cervator merged 3 commits intoMovingBlocks:developfrom
NicholasBatesNZ:particleEmitters
Conversation
Member
|
Hooray Jenkins reported success with all tests good! |
Member
|
Hooray Jenkins reported success with all tests good! |
Member
|
Tested it out and merged, thanks :-) Go forth and submit the module fixes at your convenience! |
Closed
Adrijaned
pushed a commit
to Adrijaned/DestinationSol
that referenced
this pull request
May 11, 2019
BenjaminAmos
pushed a commit
to BenjaminAmos/DestinationSol
that referenced
this pull request
Feb 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Particle Emitters now control engine sounds thus engines now have no visual or aural representation.
Residual emitter configurations have been removed and
workSoundshas been moved from all engine json files to the ship json and is optional to allow for silent emitters.Testing:
Fly around in any ship with your sound turned on
Todo:
workSoundsto the wikiNext steps:
The engine simplification PR requires this