Repository navigation
DEV-2231: 2.0 line opener — remove everything tagged for removal in 2.0, version 2.0.0.dev0 - #569
Open
ZmeiGorynych wants to merge 4 commits into
Open
ZmeiGorynych wants to merge 4 commits into
ZmeiGorynych wants to merge 4 commits into
Conversation
…tagged for 2.0, version 2.0.0.dev0)
…verything-tagged-for
…main Plan: deltas follow DEV-2182's database/ capabilities; the DEV-2234 explain adapter and build_explain_sql join the removals; the tripwire keeps the moved-path 3.0 markers; render_model_inspection's compact path is dead code. Tests: new removed-form, client-requirement, 0.9.x-backend, extras and tripwire tests (failing until the removals); tests of removed forms deleted; incidental users ported to the client-taking forms, inspect and typed probes.
…dev0 Removes the 1.5.0 no-client ingestion/drift forms, the converters' sa_engine, the 0.9.x storage adapters, --models-dir and SLAYER_MODELS_DIR, the inspect_model MCP tool, MemoryNotFoundError.identifier, the 1.5.0/1.6.0 category probes and tables, the pre-explain client adapter and build_explain_sql, and the bundled non-default drivers from the extras. Plan: a caller-owned engine keeps serving synchronous calls on the caller's thread (decisions 4/13); the caller-thread bridge tests are restored over run_sync, plus an in-memory regression test.
Contributor
|
Important Review skippedToo many files! This PR contains 152 files, which is 2 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to Team to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR on the 2.0 line. It sets the package version to
2.0.0.dev0and removes everything that was deprecated withremoval="2.0". The two must land together: the removal tripwire (tests/test_law_removal_tripwire.py) compares major versions only, so once the version is 2.x it fails for every remaining 2.0-tagged site.What is removed
ingest_datasource(ds),ingest_datasource_report(ds),ingest_datasource_idempotent(...)withoutclient=client=engine.client_for(ds), or useengine.ingest/ingest_sync/ingest_idempotentvalidate_datasource(...)withoutclient=, or withsql_clients=validate_datasource(..., client=...)DbtToSlayerConverter/OsiToSlayerConverterwithsa_engine(whereconvert()read the database itself)await converter.collect_metadata(client=...), thenconvert(); every parameter afterdata_sourceis keyword-onlyStorageBackendsubclasses that overridesave_datasourceor return a plain list from_list_memories_rows_save_datasource_impl; return(memories, failed_rows)--models-dirCLI flag and theSLAYER_MODELS_DIRvariable (the variable is now silently ignored)--storage/SLAYER_STORAGEinspect_modeltoolinspectwithentity_type="model"MemoryNotFoundError.identifiermemory_idget_column_types_sync, theget_column_typesmethods, the 1.6.0 client adapter and the dialects' category tablesget_result_column_typesexecutefor a client that has noexplain;SqlDialect.build_explain_sql()explain(statements);explain_statements()[postgres]and aiomysql in[mysql]Before and after:
Code that only existed to support these forms is gone as well, for example the per-call fallback engines,
marked_coroutine_function,run_over_caller_engine,WarningLocation, andrender_model_inspection'scompactpath.ingest_datasource_idempotentandvalidate_datasourceare now plainasync deffunctions.What is not removed
__alias rewrite, layout upgrades and type refinement.SlayerSQLClient(sa_engine=)stays. An engine the caller supplies keeps running its blocking work on the caller's thread during synchronous calls. The plan originally removed that too. A probe showed that running it inline breaks in-memory andcheck_same_threadSQLite engines, so the plan now keeps it, with restored bridge tests, an in-memory regression test and a spec requirement.removal="3.0"), ready for the forms 2.0 deprecates next.Docs and tests
inspect, and the two affected notebooks were re-executed.tests/test_removed_2_0_forms.pychecks that the removed forms are gone or refused, that the factory's client is used unadapted, and that the version is2.0.0.dev0.The migration notes for the 2.0 guide are a comment on DEV-2220. The full spec is in
openspec/changes/dev-2231-20-line-opener-remove-everything-tagged-for/.Closes DEV-2231