Skip to content

DO NOT MERGE: feat: poc: remove duration selector and hide configId on success page - #11

Draft
Luke Lovekin (lukelovekin) wants to merge 1 commit into
fix/fork-for-v4.9.13from
feat/b2c-9983/variable-consult-poc
Draft

DO NOT MERGE: feat: poc: remove duration selector and hide configId on success page#11
Luke Lovekin (lukelovekin) wants to merge 1 commit into
fix/fork-for-v4.9.13from
feat/b2c-9983/variable-consult-poc

Conversation

@lukelovekin

Copy link
Copy Markdown

What does this PR do?

POC for Variable Consult Types

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@orca-security-au orca-security-au Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@ash-d-montu
Ash Davis (ash-d-montu) marked this pull request as draft October 2, 2025 01:10
@lukelovekin Luke Lovekin (lukelovekin) changed the title feat: poc: remove duration selector and hide configId on success page DO NOT MERGE: feat: poc: remove duration selector and hide configId on success page Oct 2, 2025
@github-actions

github-actions Bot commented Oct 2, 2025

Copy link
Copy Markdown

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "DO NOT MERGE: feat: poc: remove duration selector and hide configId on success page". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant