Update to 1.20.4#7
Merged
Ampflower merged 4 commits intoModflower:trunkfrom Feb 1, 2024
unilock:1.20.4
Merged
Conversation
Signed-off-by: unilock <[email protected]>
Signed-off-by: unilock <[email protected]>
Signed-off-by: unilock <[email protected]>
Ampflower
reviewed
Feb 1, 2024
Member
Ampflower
left a comment
Ampflower
left a comment
There was a problem hiding this comment.
Seems fine, just a couple things I noticed
| ], | ||
| "depends": { | ||
| "fabricloader": ">=0.7.2", | ||
| "fabricloader": "*", |
Member
There was a problem hiding this comment.
Not exactly a needed change; if anything it probably should be vbump'd forward rather than requiring any version of loader
Author
There was a problem hiding this comment.
I agree that the change wasn't needed. It probably should've at least been bumped to >=0.14.0?
Member
There was a problem hiding this comment.
Yeah; it'll do for now at least, nothing required in a terribly specific version of the loader.
Ampflower
approved these changes
Feb 1, 2024
Member
Ampflower
left a comment
Ampflower
left a comment
There was a problem hiding this comment.
Looks good; I'll let the loader bit slide since it's not all that important
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Gradle and the dependencies for Minecraft 1.20.4, and adds a
@Uniqueannotation where one was missing.(with the 1.20.2 version, I was running into a crash about an impossible cast when shift-clicking the crafting output, IIRC)