Skip to content

test(ci): shrink workspace fixtures and move slow tests to nightly - #936

Merged
azimafroozeh merged 2 commits into
ModernRelay:mainfrom
azimafroozeh:0330-2-server-azure-cluster-seams-under-one-second
Oct 10, 2026
Merged

azimafroozeh merged 2 commits into
ModernRelay:mainfrom
azimafroozeh:0330-2-server-azure-cluster-seams-under-one-second

Conversation

@azimafroozeh

Copy link
Copy Markdown
Collaborator

What & why

Large fixtures and real deadline waits dominate workspace test time. Shrink the catalog, engine and CLI fixtures, split independent matrices for concurrent execution, and move 11 deadline and live-apply journeys to nightly alongside the two existing scale repros.

The ordinary property tests use 12 cases; nightly restores 48. Production deadlines stay unchanged. Scoped workers finish before fixture cleanup, cancellation tests reject successful exits, and executable warmups run after CI builds the debug binaries.

Backing issue / RFC

TODO: link the accepted issue or RFC before submitting.

Checklist

  • One logical change: reduce the ordinary workspace test cost.
  • Test assertions and matrix coverage retained; nightly owners checked by name.
  • CI ownership documented.
  • Maintainer verification of the supervisor test override, schema-gate observation seam and CI enrollment changes.

Local verification

  • cargo nextest run --workspace --exclude omnigraph-gqt --exclude omnigraph-gqt-served --exclude omnigraph-dst --locked --features omnigraph-engine/failpoints,omnigraph-cluster/failpoints --profile ci --test-threads 4 --no-fail-fast --status-level fail --final-status-level fail: 4,207 passed, 28 skipped.
  • All 13 enrolled nightly tests passed locally; their owner check passed. All three property tests passed with PROPTEST_CASES=48.
  • cargo fmt --all --check: passed.
  • cargo clippy --workspace --all-targets --locked -q --message-format=short -- -D warnings -W clippy::dbg_macro: passed.
  • cargo clippy --workspace --all-targets --locked --features omnigraph-engine/failpoints,omnigraph-cluster/failpoints -q --message-format=short -- -D warnings -W clippy::dbg_macro: passed.
  • CI guard self-tests and documentation checks passed. Clean library-only nextest probes passed for debug and release with a custom target directory.

Notes for reviewers

The schema-gate observation replaces a timing assumption; the supervisor cutoff override is test-only. Genuine released-binary upgrade journeys self-skipped locally because their binaries were unset. Hosted CI and its timing have not been measured for this tree.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-10T17:20:04.889913Z 6933e08 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@azimafroozeh
azimafroozeh added this pull request to the merge queue Oct 10, 2026
Merged via the queue into ModernRelay:main with commit 88ad9d5 Oct 10, 2026
33 checks passed
@azimafroozeh
azimafroozeh deleted the 0330-2-server-azure-cluster-seams-under-one-second branch October 10, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant