Repository navigation
fix: reject non-zero sub-millisecond DateTime digits - #870
Merged
azimafroozeh merged 2 commits intoOct 4, 2026
Merged
azimafroozeh merged 2 commits into
azimafroozeh merged 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #857.
DateTimeinputs such as.123456silently stored and compared as.123because storage holds milliseconds..123000.now()at millisecond precision and reject caller bindings of its reserved__nanograph_nowparameter.Backing issue / RFC
issue_857GQT regression case.Checklist
DateTimeinputs).docs/dev/invariants.md(no storage-format or publication change).Local verification
The following runs predate the latest reserved-clock and Rust list-validation fixes; those changes still need verification.
cargo test -p omnigraph-gqt --locked -q: 471 passed, including 253 corpus cases.cargo test --workspace --exclude omnigraph-gqt --exclude omnigraph-dst --locked --features omnigraph-engine/failpoints,omnigraph-cluster/failpoints --no-fail-fast -q: 3,631 passed, 26 ignored, 3 CLI managed-session failures withsession_lock_unavailablein the sandbox.cargo clippy --workspace --all-targets --locked -q --message-format=short -- -D warnings -W clippy::dbg_macro: passed.cargo fmt --all --check: passed.Vocabulary recheck:
target/debug/omnigraph-vocabulary-guard check --surface rust-string --base 92f5f953 --inventory tools/omnigraph-vocabulary-guard/graph-vocabulary-inventory.tsv --openapi openapi.jsonfails on 1,630 merge-base inventory errors before checking the patch. The same command with--surface openapipasses;--surface user-docsis unsupported. The earlier comment check failed only on unchangedexec/merge.rsbecause the branch trails upstream.Notes for reviewers
isoformat(timespec="milliseconds").ParamMapcallers must useLiteral::DateTime, or aLiteral::Listof them for[DateTime]. Nullable parameters accept whole-valueLiteral::Null; list elements cannot be null.__nanograph_nownow fail instead of replacing the engine clock.