Repository navigation
feat(gq): add list membership with scan pushdown - #803
Merged
azimafroozeh merged 2 commits intoSep 29, 2026
Merged
azimafroozeh merged 2 commits into
azimafroozeh merged 2 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
GQ rejects
$m.number in $numbers. Addinfor read filters, projections and mutation predicates, with scan pushdown for literal/parameter lists and bounded row estimates for membership on key or unique properties.Handle empty lists, null elements, Date constants and mixed numeric literals. Allow quoted traversal names such as
$a "in" $bso reservingindoes not make the edge inaccessible. Add row and plan coverage for traversal access paths, nearest ranking, and indexed data across writes, deletion and restart.Backing issue / RFC
Closes #801.
Checklist
Local verification
cargo test -p omnigraph-gqt --locked --test gq_logic_tests: 220 passed.cargo test -p omnigraph-gqt --locked --lib --test runner_dispatch: 183 library tests and 12 dispatch tests passed.cargo test -p omnigraph-engine --locked --test lance_surface_guards scalar_index_use_requires_matched_literal_type: passed, including four-value membership index checks.cargo test --workspace --exclude omnigraph-gqt --exclude omnigraph-dst --locked --features omnigraph-engine/failpoints,omnigraph-cluster/failpoints --no-fail-fast: 120 test binaries passed; four known sandbox failures remain (three CLImanaged::datatests andexternal_blob_file_policy_rejects_special_files).cargo fmt --all --checkandcargo clippy --workspace --all-targets --locked -- -D warnings -W clippy::dbg_macro: passed.python3 scripts/check-docs.pyandbash scripts/check-agents-md.sh: passed.Notes for reviewers
Pushed numeric membership follows existing
=coercion. This also changes constant-listcontainsfrom its previous in-memory behavior; the existing numeric precision difference between scan filters and projections remains outside this change.