Repository navigation
refactor: make v2 the only production query engine - #795
Merged
Merged
Conversation
azimafroozeh
force-pushed
the
engine-v2-default
branch
from
September 28, 2026 15:20
fbdbcde to
611616f
Compare
azimafroozeh
enabled auto-merge
September 28, 2026 15:21
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Production reads still default to v1, leaving v2's planner and query fixes opt-in. This makes v2 the only production query engine in v0.12.0.
engine=v2as the default and only accepted value across embedded sessions, CLI, HTTP and process settings.omnigraph-reference-engine, with GQT as its only dependent. Compiler, core and catalog remain shared.--- expect same as v1alongside written row expectations. Reference errors or different results fail the step; DST skips the comparison.engine-v2CI mode.Compatibility changes:
engine=v1is rejected;bm25()andnearest()ordering on traversal destinations returns a bad-request error; BM25 ties use identity order; multiple text predicates on one scan are conjoined.Backing issue / RFC
draft; acceptance is unconfirmed.Checklist
Local verification
Recorded on September 27; not rerun for this description:
cargo test -p omnigraph-gqt --locked: passed, including 214 corpus cases and harness suites.cargo test --locked -qfromcrates/omnigraph-dst: 108 passed, 30 ignored.cargo test --workspace --exclude omnigraph-gqt --exclude omnigraph-dst --locked --features omnigraph-engine/failpoints,omnigraph-cluster/failpoints --no-fail-fast -q: three CLI failures, reproduced individually; not established as pre-existing.cargo clippy --workspace --all-targets --locked -q --message-format=short -- -D warnings -W clippy::dbg_macro: passed.cargo fmt --all --check,bash scripts/check-agents-md.shandpython3 scripts/check-docs.py: passed.Notes for reviewers