Skip to content

feat: fix bcp47 link - #2194

Merged
skalexch merged 2 commits into
masterfrom
fix_bcp_link
Sep 8, 2026
Merged

feat: fix bcp47 link#2194
skalexch merged 2 commits into
masterfrom
fix_bcp_link

Conversation

@skalexch

@skalexch skalexch commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary:
Fixed the link to BCP 47, as I did for the reference here.

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@skalexch skalexch changed the title fix bcp47 link feat: fix bcp47 link Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚨 Code Formatting Issue 🚨

This contribution does not follow the conventions set by the Google Java Style Guide.

Please run the following command at the root of the project to fix formatting errors:

./gradlew spotlessApply
🗂️ Affected files
  • src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidLanguageCodeNotice.java

Go to the Actions Dashboard to download the full Spotless output

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 046836f
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1001 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1001 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1001 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1001 datasets, ~0%) ✅

No changes were detected due to the code change.

New Info Notices (0 out of 1001 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Info Notices (0 out of 1001 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

2 out of 1003 sources (~0 %) are corrupted.
Dataset Ref Report Exists Ref Report Readable Latest Report Exists Latest Report Readable
mdb-1114
mdb-1123
🔍 System errors for mdb-1114 (reference)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-1114 (latest)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-1123 (reference)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-1123 (latest)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]

💾 Out of Memory Check

No datasets experienced an OutOfMemoryError.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 5.57 5.88 ⬆️+0.31
Median -- 1.59 1.96 ⬆️+0.37
Standard Deviation -- 17.87 17.52 ⬇️-0.35
Minimum in References Reports mdb-299 0.35 0.67 ⬆️+0.32
Maximum in Reference Reports mdb-2014 376.90 361.23 ⬇️-15.66
Minimum in Latest Reports mdb-812 0.38 0.51 ⬆️+0.13
Maximum in Latest Reports mdb-2014 376.90 361.23 ⬇️-15.66
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 574.83 MiB 578.81 MiB ⬆️+3.98 MiB
Median -- 324.54 MiB 322.16 MiB ⬇️-2.39 MiB
Standard Deviation -- 1.01 GiB 1.04 GiB ⬆️+25.83 MiB
Minimum in References Reports mdb-107 42.30 MiB 47.48 MiB ⬆️+5.18 MiB
Maximum in Reference Reports mdb-2393 10.49 GiB 9.45 GiB ⬇️-1.04 GiB
Minimum in Latest Reports mdb-1812 407.93 MiB 40.61 MiB ⬇️-367.32 MiB
Maximum in Latest Reports mdb-2393 10.49 GiB 9.45 GiB ⬇️-1.04 GiB

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 41aef99
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1001 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1001 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1001 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1001 datasets, ~0%) ✅

No changes were detected due to the code change.

New Info Notices (0 out of 1001 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Info Notices (0 out of 1001 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

2 out of 1003 sources (~0 %) are corrupted.
Dataset Ref Report Exists Ref Report Readable Latest Report Exists Latest Report Readable
mdb-1114
mdb-1123
🔍 System errors for mdb-1114 (reference)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-1114 (latest)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-1123 (reference)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-1123 (latest)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]

💾 Out of Memory Check

No datasets experienced an OutOfMemoryError.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 5.33 5.59 ⬆️+0.26
Median -- 1.52 1.89 ⬆️+0.38
Standard Deviation -- 15.03 15.03 ⬇️-0.01
Minimum in References Reports mdb-912 0.32 0.45 ⬆️+0.13
Maximum in Reference Reports mdb-2014 248.17 243.99 ⬇️-4.18
Minimum in Latest Reports mdb-1028 0.43 0.41 ⬇️-0.01
Maximum in Latest Reports mdb-2014 248.17 243.99 ⬇️-4.18
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 578.82 MiB 573.48 MiB ⬇️-5.35 MiB
Median -- 327.93 MiB 323.93 MiB ⬇️-4.00 MiB
Standard Deviation -- 1.03 GiB 1021.72 MiB ⬇️-28.28 MiB
Minimum in References Reports mdb-2297 38.38 MiB 411.93 MiB ⬆️+373.54 MiB
Maximum in Reference Reports mdb-2393 9.96 GiB 10.60 GiB ⬆️+656.47 MiB
Minimum in Latest Reports mdb-79 415.93 MiB 38.80 MiB ⬇️-377.12 MiB
Maximum in Latest Reports mdb-2393 9.96 GiB 10.60 GiB ⬆️+656.47 MiB

@skalexch
skalexch merged commit 3864b92 into master Sep 8, 2026
103 checks passed
@skalexch
skalexch deleted the fix_bcp_link branch September 8, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants