Skip to content

chore: update zed mcp config#228

Merged
stephantul merged 1 commit into
mainfrom
fix-zed-mcp-server-config
Jul 22, 2026
Merged

chore: update zed mcp config#228
stephantul merged 1 commit into
mainfrom
fix-zed-mcp-server-config

Conversation

@stephantul

Copy link
Copy Markdown
Contributor

The zed MCP config got changed recently. Whenever I installed semble, I would get a warning that my settings were out of date. Zed autofixed this, so nothing broke. This PR removes our outdated format and replaces it with the newer one. I tested and installing now no longer triggers the warning toast and auto-update.

@stephantul
stephantul requested a review from Pringled July 22, 2026 07:49
@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The current Zed path looks mergeable, with a compatibility risk for older installations.

  • The new entry matches the current command-and-arguments format.
  • Reinstallation fully replaces the existing entry, which can remove a field required by older Zed versions.

src/semble/installer/agents.py

Reviews (1): Last reviewed commit: "chore: update zed mcp config" | Re-trigger Greptile


_ZED_SERVER_CONFIG: dict[str, object] = { # Zed requires "source": "custom" for manual servers
"source": "custom",
_ZED_SERVER_CONFIG: dict[str, object] = { # Zed: command/args only, no "source"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Older Zed Config Is Overwritten

When an existing installation still depends on source: "custom", reinstalling replaces the complete context_servers.semble value and removes that field. Without Zed version detection or a stated minimum version, this can make Semble disappear for users running an older compatible Zed release.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Difficult to account for IMO. This is a two-three month old change AFAIK. So not very recent.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point — if this format change landed 2–3 months ago, the vast majority of active Zed users will be on a version that supports it already. The compatibility concern is minimal in practice. No issue here.

Tip: You can customize Greptile's behavior for this repo with .greptile/rules.md and .greptile/config.json.

@stephantul
stephantul merged commit 36605fc into main Jul 22, 2026
16 checks passed
@stephantul
stephantul deleted the fix-zed-mcp-server-config branch July 22, 2026 07:57
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/semble/installer/agents.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants