Turn Priority into a non-extendable interface#76
Closed
Jonathing wants to merge 1 commit intoMinecraftForge:masterfrom
Closed
Turn Priority into a non-extendable interface#76Jonathing wants to merge 1 commit intoMinecraftForge:masterfrom
Jonathing wants to merge 1 commit intoMinecraftForge:masterfrom
Conversation
Member
|
Not really a fan of this. Ya some boiler plate is annoying but i think this is worse. |
Contributor
|
Not a fan either. For newbie Java devs they may not yet know that those are static fields and try to find a way to get an instance, then go to the UtilityInterface and see it's public and think it needs to be implemented or something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is more of a nitpick/personal preference than anything else. The primary reason for this is to remove the boilerplate for the fields of the byte fields in the Priority class, but it also aligns with how the other interfaces in the EventBus API primarily convey information about the types the consumer can work with.
To preserve non-extensibility, I've created an empty internal interface simply named
UtilityInterface, whose name entails thatPriorityis a utility interface and not an actual type that can be interacted with.