Skip to content

7124: add documentation for the new launch modes - #158

Merged
Kayla Cinnamon (cinnamon-msft) merged 4 commits into
MicrosoftDocs:release-1.5from
Don-Vito:fet/7124-focusmode-docs
Nov 10, 2020
Merged

Kayla Cinnamon (cinnamon-msft) merged 4 commits into
MicrosoftDocs:release-1.5from
Don-Vito:fet/7124-focusmode-docs

Conversation

@Don-Vito

@Don-Vito Don-Vito commented Oct 9, 2020

Copy link
Copy Markdown
Contributor

This PR documents new launch mode values introduced in microsoft/terminal#7873 to address microsoft/terminal#7124.

Not sure what is the correct contribution procedure for such changes. Hence, opening this change as a draft PR to master (please do not merge 😄 )

@opbld30

opbld30 commented Oct 9, 2020

Copy link
Copy Markdown

Docs Build status updates of commit 32803a0:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/global-settings.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33

opbld33 commented Oct 10, 2020

Copy link
Copy Markdown

Docs Build status updates of commit 049a1f4:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/customize-settings/global-settings.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33

opbld33 commented Oct 13, 2020

Copy link
Copy Markdown

Docs Build status updates of commit c227da4:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/customize-settings/global-settings.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@zadjii-msft Mike Griese (zadjii-msft) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna block this only until the 1.5 release branch is created, so we can make sure to re-target this to the correct branch.

Also, you should add notes to make it clear which version these properties were added in.

Otherwise, great work here!

Comment thread TerminalDocs/command-line-arguments.md Resolved
@opbld32

opbld32 commented Oct 16, 2020

Copy link
Copy Markdown

Docs Build status updates of commit 7a10c7b:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/customize-settings/global-settings.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@Don-Vito
Don-Vito marked this pull request as ready for review October 16, 2020 10:04
@cinnamon-msft
Kayla Cinnamon (cinnamon-msft) changed the base branch from master to release-1.5 November 10, 2020 21:56
@cinnamon-msft

Copy link
Copy Markdown
Collaborator

I created the release-1.5 branch and have pointed this PR towards that one.

@cinnamon-msft
Kayla Cinnamon (cinnamon-msft) merged commit bf949f9 into MicrosoftDocs:release-1.5 Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants