Doc to help users set PSReadLine colors and PowerShell colors for light themed terminal #9358

Activity

1. Steve Lee (SteveL-MSFT)

   added

   issue-doc-ideaIssue - request for new contentIssue - request for new content

   needs-triageWaiting - Needs triageWaiting - Needs triage

   on Oct 25, 2022
2. sdwheeler commented on Oct 25, 2022

   

   Sean Wheeler (sdwheeler)

   on Oct 25, 2022

   Contributor

   More actions

   Steve Lee (@SteveL-MSFT) Do you have some sample themes we can document?
3. Sean Wheeler (sdwheeler)

   added

   needs-more-infoWaiting - for more informationWaiting - for more information

   and removed

   needs-triageWaiting - Needs triageWaiting - Needs triage

   on Oct 25, 2022
4. sdwheeler commented on Oct 25, 2022

   

   Sean Wheeler (sdwheeler)

   on Oct 25, 2022

   Last edited by sdwheeler

   Contributor

   More actions

   • https://www.towermarketing.net/blog/developing-an-accessible-color-palette
   • https://medium.com/envoy-design/how-to-design-an-accessible-color-scheme-4a13ca12c92b
   • https://github.com/PowerShell/vscode-powershell/blob/main/themes/theme-psise/theme.json
5. DHowett commented on Nov 8, 2022

   

   Dustin L. Howett (DHowett)

   on Nov 8, 2022

   Last edited by DHowett

   More actions

   For what it's worth, I wholeheartedly believe that the DefaultTokenColor, TypeColor and ContinuationPromptColor should be \e[39m. In almost all default color schemes on many terminals that color is the same as white (on dark-theme terminals) so it doesn't present too much of a compatibility issue. At the same time, it opens up the possibility that PSReadline automatically performs better on light-theme terminals. The cost is so low¹ and the benefit is so great² that we'd be remiss in not considering it.

   ¹ Terminals that do not support 39 and 49 are rare in the wild. Even the Windows Console supports it in its earliest versions. To quote PowerShell/PSReadLine#1626:

   I went back to the Windows source code and confirmed: conhost supports 39;49 everywhere ENABLE_VIRTUAL_TERMINAL_PROCESSING is supported.

   ² The benefit is, "nobody will ever complain about this again." That doesn't even account for all the people who just leave or change shells or never learn that there is documentation telling them the "right" way to "fix" it. 😄

   👍React with 👍1Reacted by Mike Griese

   ❤️React with ❤️1Reacted by Ben Stolovitz
6. Sean Wheeler (sdwheeler)

   self-assigned this

   on Dec 6, 2022
7. sdwheeler commented on Dec 6, 2022

   

   Sean Wheeler (sdwheeler)

   on Dec 6, 2022

   Last edited by sdwheeler

   Contributor

   More actions

   Dustin L. Howett (@DHowett) What do you think of these colors for a light theme? Most of these colors come directly from the ISE's light-mode configuration.

   $PSROptions = @{
       Colors  = @{
           Command                  = $PSStyle.Foreground.FromRGB(0x0000FF)
           Comment                  = $PSStyle.Foreground.FromRGB(0x006400)
           ContinuationPrompt       = $PSStyle.Foreground.FromRGB(0x0000FF)
           Default                  = $PSStyle.Foreground.FromRGB(0x0000FF)
           Emphasis                 = $PSStyle.Foreground.FromRGB(0x287BF0)
           Error                    = $PSStyle.Foreground.FromRGB(0xE50000)
           InlinePrediction         = $PSStyle.Foreground.FromRGB(0x93A1A1)
           Keyword                  = $PSStyle.Foreground.FromRGB(0x00008b)
           ListPrediction           = $PSStyle.Foreground.FromRGB(0x06DE00)
           Member                   = $PSStyle.Foreground.FromRGB(0x000000)
           Number                   = $PSStyle.Foreground.FromRGB(0x800080)
           Operator                 = $PSStyle.Foreground.FromRGB(0x757575)
           Parameter                = $PSStyle.Foreground.FromRGB(0x000080)
           String                   = $PSStyle.Foreground.FromRGB(0x8b0000)
           Type                     = $PSStyle.Foreground.FromRGB(0x008080)
           Variable                 = $PSStyle.Foreground.FromRGB(0xff4500)
           ListPredictionSelected   = $PSStyle.Background.FromRGB(0x93A1A1)
           Selection                = $PSStyle.Background.FromRGB(0x00BFFF)
       }
   }
   Set-PSReadLineOption @PSROptions
8. Sean Wheeler (sdwheeler)

   added

   area-conceptualArea - Conceptual articlesArea - Conceptual articles

   and removed

   needs-more-infoWaiting - for more informationWaiting - for more information

   on Dec 7, 2022
9. Sean Wheeler (sdwheeler)

   closed this as completedin #9539on Dec 7, 2022
10. Sean Wheeler (sdwheeler)

    added a commit that references this issue on Dec 7, 2022

    Fixes #9358 - Add article about using light themes (#9539)

    ...

    This issue will close once commit 36883e8 is merged into the 'main' branch.

    36883e8
11. DHowett commented on Dec 8, 2022

    

    Dustin L. Howett (DHowett)

    on Dec 8, 2022

    More actions

    Sean Wheeler (@sdwheeler) hey, those look really good!