Conversation
Replace the third-party `wiki` PyPI package with a local copy under wiki/, consolidate its templates into the app, and remove unused Bootstrap static files. Former transitive deps (django-mptt, django-nyt, django-sekizai, bleach, markdown, pymdown-extensions) are now listed as direct dependencies.
django-nyt 1.5.0 introduced a hard django<5.3 upper bound, blocking the Django 6.0 upgrade. Since django-wiki is already vendored, vendor django-nyt alongside it and remove it as an external dependency. Also fixes a Python 3.14 JSON serialization bug where naturaltime() returned a lazy __proxy__ object that json.dumps could not serialize. Adds tests covering models, notify/subscribe/unsubscribe utilities, and views.
- Apply ruff fixes throughout the vendored django_nyt app: convert relative to absolute imports, fix model field/method ordering (DJ012), replace assert statements with proper exceptions, convert f-strings in logging calls to % format, replace open() with Path.open(), and wrap long docstring lines. - Add django_nyt/migrations to per-file-ignores.
bpepple
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
django-wikianddjango-nytas internal apps rather than uv dependencies, giving us full control to apply fixes and customizations without waiting on upstream releasesChanges
Vendoring
wiki/— django-wiki vendored as an internal app; templates moved intowiki/templates/django_nyt/— django-nyt notification backend vendored as an internal appTests
tests/wiki/— covers models, views, permissions, and all plugins (attachments, images, links, notifications, globalhistory)tests/django_nyt/— covers models, views, and utilsCleanup
wiki/anddjango_nyt/TestCollectionItemModel::test_collection_item_with_date_read(used timezone-awaredatetimefor aDateTimeField)