Skip to content

Use shell_words to split the outer shell so that more complex outer shells can be used.#302

Merged
maxdymond merged 1 commit intomainfrom
issue/62/fixshells
Jul 11, 2023
Merged

Use shell_words to split the outer shell so that more complex outer shells can be used.#302
maxdymond merged 1 commit intomainfrom
issue/62/fixshells

Conversation

@maxdymond
Copy link
Copy Markdown
Member

Why this change?

Fixes #62

Relevant testing

Local testing:

shell:
  inner: bash
  outer: su - root

becomes

08:55:42 [DEBUG] (1) floki::command: - and args: ["su", "-", "root", "-c", "bash"]

Contributor notes

Anything you think will be useful for reviewers.

Checks

These aren't hard requirements, just guidelines

  • New/modified Rust code formatted with cargo fmt
  • Documentation and README.md updated for this change, if necessary
  • CHANGELOG.md updated for this change

…hells can be used.

Fixes #62

Signed-off-by: Max Dymond <max.dymond@microsoft.com>
@maxdymond maxdymond requested a review from rlupton20 July 11, 2023 08:59
@maxdymond maxdymond merged commit cd19d08 into main Jul 11, 2023
@maxdymond maxdymond deleted the issue/62/fixshells branch April 11, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inner shell and outer shell have different restrictions

1 participant