chore(changelog-check): add action-sha input for correct repository checkout#63
Merged
Merged
Conversation
Add required action-sha input to ensure we checkout the same version of github-tools that was used in the workflow call.
edc4961 to
5af9094
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an
action-shainput to the changelog check workflow to ensure we're using the correct version of the github-tools repository. This is necessary because:@91e349d177db2c569e03c7aa69d2acb404b62f75), we need to use that exact same SHA when checking out the repositorygithub.action_ref,github.sha, or other GitHub context variables didn't work because:github.action_refincludes the full ref path (e.g.,+refs/heads/v4*:refs/remotes/origin/v4*)github.sharefers to the current workflow run's SHALong-term Plan
This is a short-term fix. In the future, we plan to:
Changes
action-shato the workflow${{ inputs.action-sha }}Testing
This change is being tested in MetaMask/core#5693 where we're updating the changelog check workflow to use the new
action-shainput.Test with a workflow call using a specific SHA:
Verify that the checkout works correctly and matches the version used in the workflow call