feat: GH action to remind developers to add release notes in CHANGELOG.md #57
feat: GH action to remind developers to add release notes in CHANGELOG.md #57cryptodev-2s merged 7 commits intomainfrom
Conversation
|
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
e04ef80 to
a0c48b8
Compare
|
@SocketSecurity ignore npm/diff@5.2.0 |
d9d7fba to
316ce39
Compare
316ce39 to
9449ec2
Compare
|
@jake-perkins @Gudahtt @itsyoboieltr |
| ] as const; | ||
|
|
||
| type RepositoryName = typeof REPOSITORY_NAMES[number]; | ||
| type RepositoryName = (typeof REPOSITORY_NAMES)[number]; |
There was a problem hiding this comment.
It’s not related to the newly added workflow, but the lint workflow was failing.
Error: 18:23 error Replace `typeof·REPOSITORY_NAMES` with `(typeof·REPOSITORY_NAMES)` prettier/prettier
|
LGTM, i think the git cli is more intensive than the API calls for the changelog but it's not a big deal. As long as it works for your monorepo case and the client repositories it should be fine |
|
Thanks @jake-perkins can I get a another review I just updated the ref to use main instead of the testing branch |
This PR introduces a new CI workflow that enforces the inclusion of a CHANGELOG entry for any changes made by developers. It supports both single-package repositories and monorepos.
Usage examples:
Extension: MetaMask/metamask-extension#31706
Core (Monorepo): MetaMask/core#5575
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3678