-
-
Notifications
You must be signed in to change notification settings - Fork 5
Auto-skip release validation columns from PR labels on main release tabs #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+85
−7
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
eabec49
Initial plan
Copilot ff2c81c
feat: auto-skip release validation from PR labels
Copilot de0de82
fix: use existing template comments column
Copilot a3726b2
refactor: clarify release sheet row column placeholders
Copilot d8b8462
fix: apply skip logic to both main and release tabs
jvbriones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
processTabpasses wrongrepoformat to auto-skipMedium Severity
processTabis defined at module scope so thereporeference on this line resolves to the module-levelrepo("MetaMask/metamask-extension", fullowner/repoformat) rather than the repo-name-only value ("metamask-extension") thatprocessReporeceives as its parameter.applyAutoSkipToRowandgetAutoSkipLabelsForPRaccept a parameter namedrepoNameand happen to work only becauseendsWith('-mobile')/endsWith('-extension')match both formats. If the detection logic is ever tightened, this will silently break. The repo name (not the full path) needs to be passed explicitly, e.g. as a parameter toprocessTab.Additional Locations (2)
.github/scripts/post-merge-validation-tracker.mjs#L8-L9.github/scripts/post-merge-validation-tracker.mjs#L850-L851There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The finding is accurate as a code hygiene observation — processTab closing over the module-level repo instead of receiving an explicit parameter is a latent coupling issue — but it is not a live bug for our two supported repos: