Skip to content

fix: sanitize .yarnrc.yml in publish-preview to prevent token exfiltration #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cryptodev-2s merged 2 commits into from
Mar 17, 2026
Merged

fix: sanitize .yarnrc.yml in publish-preview to prevent token exfiltration #227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4782244
fix: sanitize .yarnrc.yml scoped registry overrides in publish-preview
cryptodev-2s Mar 17, 2026
e8126ac
fix: also strip npmPublishRegistry from .yarnrc.yml
cryptodev-2s Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/publish-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,15 @@ jobs:
echo "::error::No package.json files found to validate"
exit 1
fi
# Strip registry overrides from .yarnrc.yml to prevent registry
# redirects that could exfiltrate the NPM token. npmPublishRegistry
# takes precedence over npmRegistryServer for yarn npm publish, and
# npmScopes can override per-scope. YARN_NPM_REGISTRY_SERVER env var
Copy link
Copy Markdown
Contributor

@mcmire mcmire Mar 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we no longer need to set YARN_NPM_REGISTRY_SERVER below, then? The registry URL is already configured in each workspace package's package.json (under publishConfig.registry), so we shouldn't need to override it.

Copy link
Copy Markdown
Contributor Author

@cryptodev-2s cryptodev-2s Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it's more defense-in-depth.

Copy link
Copy Markdown
Contributor

@mcmire mcmire Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, because a PR could also update the registry for a package by updating its package.json. Okay this change makes sense.

# only overrides npmRegistryServer, not the others.
if [[ -f .yarnrc.yml ]]; then
echo "Stripping registry config from .yarnrc.yml"
yq -i 'del(.npmRegistryServer) | del(.npmPublishRegistry) | del(.npmScopes)' .yarnrc.yml
fi
for f in "${manifests[@]}"; do
# Strip lifecycle scripts that run during pack/publish
if jq -e '.scripts // {} | keys[] | select(test("^(pre|post)?(pack|publish|prepare)$"))' "$f" > /dev/null 2>&1; then
Expand Down
Loading