refactor!: Rewrite check changelog to action#164
Merged
Conversation
Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com>
| github-tools-ref: | ||
| description: 'The SHA of the action to use. Defaults to the current action ref, and usually does not need to be changed.' | ||
| required: false | ||
| default: ${{ github.action_ref }} |
There was a problem hiding this comment.
Bug: Context expressions invalid in action input defaults
GitHub Actions metadata files (action.yml) do not support context expressions (like ${{ github.action_repository }}) in input default values. These will be interpreted as literal strings (e.g., "${{ github.action_repository }}"), causing the checkout step to fail. Remove the defaults and handle the fallback logic directly in the step inputs (e.g., repository: ${{ inputs.github-tools-repository || github.action_repository }}).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rewrites the check changelog workflow to an action, letting us use
github.action_repositoryandgithub.action_ref, removing the need for specifying an action ref.Note
Replaces the reusable workflow with a composite action for changelog checks, defaulting to current action repo/ref and updating checkout/setup steps.
/.github/actions/check-changelog/action.yml:base-branch,head-ref,labels,pr-number,repo, plusgithub-tools-repositoryandgithub-tools-ref(defaulting togithub.action_repositoryandgithub.action_ref)../.github-tools, enables Corepack, sets up Node via./.github-tools/.nvmrc, installs deps, and runschangelog:check./.github/workflows/changelog-check.yml.Written by Cursor Bugbot for commit 9d0012c. This will update automatically on new commits. Configure here.