Skip to content

refactor!: Rewrite check changelog to action#164

Merged
Mrtenz merged 3 commits intomainfrom
mrtenz/check-changelog-action
Nov 20, 2025
Merged

refactor!: Rewrite check changelog to action#164
Mrtenz merged 3 commits intomainfrom
mrtenz/check-changelog-action

Conversation

@Mrtenz
Copy link
Copy Markdown
Member

@Mrtenz Mrtenz commented Nov 20, 2025

This rewrites the check changelog workflow to an action, letting us use github.action_repository and github.action_ref, removing the need for specifying an action ref.


Note

Replaces the reusable workflow with a composite action for changelog checks, defaulting to current action repo/ref and updating checkout/setup steps.

  • GitHub Actions:
    • New composite action /.github/actions/check-changelog/action.yml:
      • Accepts base-branch, head-ref, labels, pr-number, repo, plus github-tools-repository and github-tools-ref (defaulting to github.action_repository and github.action_ref).
      • Performs label gate, checks out target repo (actions/checkout@v5), logs selected tools repo/ref, checks out tools into ./.github-tools, enables Corepack, sets up Node via ./.github-tools/.nvmrc, installs deps, and runs changelog:check.
    • Removed reusable workflow /.github/workflows/changelog-check.yml.

Written by Cursor Bugbot for commit 9d0012c. This will update automatically on new commits. Configure here.

Comment thread .github/actions/check-changelog/action.yml
Copy link
Copy Markdown
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change otherwise the changes looks good to me!

Comment thread .github/actions/check-changelog/action.yml Outdated
Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com>
@Mrtenz Mrtenz requested a review from cryptodev-2s November 20, 2025 14:27
github-tools-ref:
description: 'The SHA of the action to use. Defaults to the current action ref, and usually does not need to be changed.'
required: false
default: ${{ github.action_ref }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Context expressions invalid in action input defaults

GitHub Actions metadata files (action.yml) do not support context expressions (like ${{ github.action_repository }}) in input default values. These will be interpreted as literal strings (e.g., "${{ github.action_repository }}"), causing the checkout step to fail. Remove the defaults and handle the fallback logic directly in the step inputs (e.g., repository: ${{ inputs.github-tools-repository || github.action_repository }}).

Fix in Cursor Fix in Web

Copy link
Copy Markdown
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz merged commit be06c31 into main Nov 20, 2025
19 checks passed
@Mrtenz Mrtenz deleted the mrtenz/check-changelog-action branch November 20, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants