feat(accounts-controller): use KeyringV1Adapter for SnapKeyring (v2) accounts

[ccharly]

Explanation

I introduced a new v1 adapter for SnapKeyringV2 since the v2 interface has an incompatible getAccounts method that cannot be used by the KeyringController.

So the new SnapKeyringV2 will now be "wrapped" by their v1 adapter AND also be available as normal v2 keyring instances (using the same ref).

This allows us to query them with :getKeyringsByType and to make synchronous calls (something that we will have to change someday) AND to make them compatible with the KeyrignController keyrings lifecycle!

References

N/A

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

Note

Medium Risk
Changes how Snap v2 accounts are discovered by unwrapping KeyringV1Adapter instances returned from KeyringController:getKeyringsByType, which can affect account synchronization during KeyringController:stateChange. Dependency bumps (including adding @metamask/keyring-sdk) may introduce subtle behavior changes in keyring interop.

Overview
Snap v2 account lookup is now routed through KeyringV1Adapter. AccountsController’s Snap v2 path (#getAccountFromSnapKeyringV2) now expects KeyringController:getKeyringsByType(KeyringType.Snap) to return v1-adapted keyrings and uses KeyringV1Adapter.unwrap() to reach the underlying SnapKeyringV2 for lookupByAddress and snapId.

Tests were updated to wrap mocked SnapKeyringV2 instances in KeyringV1Adapter, and package deps/changelogs were updated (adds @metamask/keyring-sdk, bumps @metamask/keyring-utils across affected packages, and updates yarn.lock).

^{Reviewed by Cursor Bugbot for commit f2ae211. Bugbot is set up for automated code reviews on this repo. Configure here.}

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​metamask/​keyring-utils@​3.2.0 ⏵ 3.3.1	+1		+1	+7
	@​metamask/​keyring-sdk@​2.0.2 ⏵ 2.1.1	+1		+1	+1

View full report