Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6fa961b. Configure here.
juanmigdr
reviewed
May 5, 2026
| } | ||
| }, | ||
| "packages/assets-controllers/src/TokensController.test.ts": { | ||
| "@typescript-eslint/explicit-function-return-type": { |
Member
There was a problem hiding this comment.
Surprised this count got increased, no chance we can avoid this? 🤔
Contributor
Author
There was a problem hiding this comment.
i can fix it yes , will push in a short moment
juanmigdr
reviewed
May 5, 2026
| * Metadata matches `GET /v3/assets` on `tokens.api.cx.metamask.io` (assetIds CAIP-19). | ||
| */ | ||
| export const MUSD_TOKEN_DETECTION_CHAIN_IDS = [ | ||
| '0x1', // Ethereum mainnet (eip155:1) |
Member
There was a problem hiding this comment.
Surprised these need hardcoding, is there no ChainId enum?
Contributor
Author
There was a problem hiding this comment.
hmmm let me clean this later , we can use ChainId here indeed
juanmigdr
approved these changes
May 5, 2026
Prithpal-Sooriya
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
UI PR: MetaMask/metamask-extension#42390
References
Checklist
Note
Medium Risk
Changes token discovery/import behavior for mUSD across multiple chains, which could impact whether the asset appears by default and how it is re-added across account/network changes. Risk is mitigated by added unit tests, but regressions could affect token visibility/import timing.
Overview
Switches default mUSD handling from upfront
TokensControllerstate seeding to detection-based discovery on Ethereum mainnet (0x1), Linea (0xe708), and Monad mainnet (0x8f), and drops Monad testnet from the default list.TokenDetectionControllernow merges mUSD metadata into the in-memory token list cache and ensures mUSD is included in detection slices (polling/WS/RPC), including a special case to add mUSD even when RPC returns a zero balance.TokenBalancesControllernow also schedules mUSD for import on those chains even when balances are zero.Removes the prior mUSD seeding/event-subscription paths from
TokensController(and related messenger allowed events), updates tests accordingly, and adds shared mUSD constants/metadata plus changelog and lint-suppression updates.Reviewed by Cursor Bugbot for commit 6fa961b. Bugbot is set up for automated code reviews on this repo. Configure here.