Skip to content

chore: Expose missing PermissionController methods through the messenger#8675

Merged
GuillaumeRx merged 2 commits intomainfrom
gr/expose-permission-controller-methods
May 4, 2026
Merged

chore: Expose missing PermissionController methods through the messenger#8675
GuillaumeRx merged 2 commits intomainfrom
gr/expose-permission-controller-methods

Conversation

@GuillaumeRx
Copy link
Copy Markdown
Contributor

@GuillaumeRx GuillaumeRx commented May 4, 2026

Explanation

This exposes missing methods used in the clients through the messenger after #8201

References

Progresses https://consensyssoftware.atlassian.net/browse/WPC-989

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Low risk: this primarily expands the messenger-exposed API surface and TypeScript action types without changing permission logic, but consumers may start depending on these newly exposed actions.

Overview
Exposes additional PermissionController methods via the messenger by adding new action types and including them in the controller’s MESSENGER_EXPOSED_METHODS allowlist.

Newly exposed actions include acceptPermissionsRequest, rejectPermissionsRequest, revokePermission, updatePermissionsByCaveat, and getPermission, with corresponding exports from the package entrypoint and a changelog entry documenting the additions.

Reviewed by Cursor Bugbot for commit 092f6a5. Bugbot is set up for automated code reviews on this repo. Configure here.

@GuillaumeRx GuillaumeRx marked this pull request as ready for review May 4, 2026 13:30
@GuillaumeRx GuillaumeRx requested review from a team as code owners May 4, 2026 13:30
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@GuillaumeRx GuillaumeRx added this pull request to the merge queue May 4, 2026
Merged via the queue into main with commit fe43b08 May 4, 2026
366 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/expose-permission-controller-methods branch May 4, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants