chore: Expose missing KeyringController methods through the messenger#8674
Merged
GuillaumeRx merged 2 commits intomainfrom May 4, 2026
Merged
chore: Expose missing KeyringController methods through the messenger#8674GuillaumeRx merged 2 commits intomainfrom
KeyringController methods through the messenger#8674GuillaumeRx merged 2 commits intomainfrom
Conversation
fa3a2d0 to
6ab7639
Compare
hmalik88
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This exposes missing methods used in the clients through the messenger after #8391
References
Checklist
Note
Medium Risk
Broadens the messenger API surface to include password/key export and lock/unlock-related actions, which are sensitive operations even though underlying implementations are unchanged.
Overview
Exposes additional
KeyringControllercapabilities via the messenger. The controller now allowlists and types new messenger actions forchangePassword,verifyPassword,submitPassword,submitEncryptionKey,setLocked,exportEncryptionKey,exportAccount,importAccountWithStrategy, andgetAccountKeyringType.Updates the generated method action-type union/exports and adds an Unreleased changelog entry documenting the newly available actions.
Reviewed by Cursor Bugbot for commit 6ab7639. Bugbot is set up for automated code reviews on this repo. Configure here.