Skip to content

chore: Expose missing KeyringController methods through the messenger#8674

Merged
GuillaumeRx merged 2 commits intomainfrom
gr/expose-keyring-controller-methods
May 4, 2026
Merged

chore: Expose missing KeyringController methods through the messenger#8674
GuillaumeRx merged 2 commits intomainfrom
gr/expose-keyring-controller-methods

Conversation

@GuillaumeRx
Copy link
Copy Markdown
Contributor

@GuillaumeRx GuillaumeRx commented May 4, 2026

Explanation

This exposes missing methods used in the clients through the messenger after #8391

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Broadens the messenger API surface to include password/key export and lock/unlock-related actions, which are sensitive operations even though underlying implementations are unchanged.

Overview
Exposes additional KeyringController capabilities via the messenger. The controller now allowlists and types new messenger actions for changePassword, verifyPassword, submitPassword, submitEncryptionKey, setLocked, exportEncryptionKey, exportAccount, importAccountWithStrategy, and getAccountKeyringType.

Updates the generated method action-type union/exports and adds an Unreleased changelog entry documenting the newly available actions.

Reviewed by Cursor Bugbot for commit 6ab7639. Bugbot is set up for automated code reviews on this repo. Configure here.

@GuillaumeRx GuillaumeRx force-pushed the gr/expose-keyring-controller-methods branch from fa3a2d0 to 6ab7639 Compare May 4, 2026 12:55
@GuillaumeRx GuillaumeRx marked this pull request as ready for review May 4, 2026 13:02
@GuillaumeRx GuillaumeRx requested review from a team as code owners May 4, 2026 13:02
@GuillaumeRx GuillaumeRx added this pull request to the merge queue May 4, 2026
Merged via the queue into main with commit 7f2126a May 4, 2026
366 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/expose-keyring-controller-methods branch May 4, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants