feat(multichain-account-service): filter KeyringController locked errors from sentry reporting#8619
Merged
Merged
Conversation
ccharly
reviewed
Apr 28, 2026
ccharly
approved these changes
Apr 28, 2026
KeyringController locked errors from sentry reporting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
There's instances where we can hit keyring controller is locked errors, we should not be reporting those. Added a function to determine if an error is a keyring controller locked error and used that to prevent sentry reporting.
Checklist
Note
Low Risk
Low risk: only adjusts error classification for Sentry capture, treating
KeyringController"ControllerLocked" as a warning like timeouts and adding tests around the new behavior.Overview
Prevents noisy Sentry reporting by treating
KeyringControllerErrorMessage.ControllerLockederrors the same asTimeoutError: they are now logged as warnings and not sent tocaptureException.Adds
isKeyringControllerLockedErrortoproviders/utils, updatesreportErrorto use it, and introduces unit tests covering both the new predicate and the updated reporting behavior; changelog is updated accordingly.Reviewed by Cursor Bugbot for commit 9aea456. Bugbot is set up for automated code reviews on this repo. Configure here.