Skip to content

feat(multichain-account-service): filter KeyringController locked errors from sentry reporting#8619

Merged
hmalik88 merged 7 commits into
mainfrom
hm/filter-sentry-errors
Apr 28, 2026
Merged

feat(multichain-account-service): filter KeyringController locked errors from sentry reporting#8619
hmalik88 merged 7 commits into
mainfrom
hm/filter-sentry-errors

Conversation

@hmalik88
Copy link
Copy Markdown
Contributor

@hmalik88 hmalik88 commented Apr 28, 2026

Explanation

There's instances where we can hit keyring controller is locked errors, we should not be reporting those. Added a function to determine if an error is a keyring controller locked error and used that to prevent sentry reporting.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Low risk: only adjusts error classification for Sentry capture, treating KeyringController "ControllerLocked" as a warning like timeouts and adding tests around the new behavior.

Overview
Prevents noisy Sentry reporting by treating KeyringControllerErrorMessage.ControllerLocked errors the same as TimeoutError: they are now logged as warnings and not sent to captureException.

Adds isKeyringControllerLockedError to providers/utils, updates reportError to use it, and introduces unit tests covering both the new predicate and the updated reporting behavior; changelog is updated accordingly.

Reviewed by Cursor Bugbot for commit 9aea456. Bugbot is set up for automated code reviews on this repo. Configure here.

@hmalik88 hmalik88 marked this pull request as ready for review April 28, 2026 13:22
@hmalik88 hmalik88 requested review from a team as code owners April 28, 2026 13:22
Comment thread packages/multichain-account-service/CHANGELOG.md Outdated
Comment thread packages/multichain-account-service/src/providers/utils.ts
Comment thread packages/multichain-account-service/src/errors.ts
@hmalik88 hmalik88 enabled auto-merge April 28, 2026 14:06
@ccharly ccharly changed the title chore: filter keyring controller locked errors from sentry reporting feat(multichain-account-service): filter KeyringController locked errors from sentry reporting Apr 28, 2026
@hmalik88 hmalik88 added this pull request to the merge queue Apr 28, 2026
Merged via the queue into main with commit fa7e1a2 Apr 28, 2026
362 checks passed
@hmalik88 hmalik88 deleted the hm/filter-sentry-errors branch April 28, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants