Skip to content

chore: Expose KeyringController:signTransaction through messenger #8408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mrtenz merged 2 commits into from
Apr 8, 2026
Merged

chore: Expose KeyringController:signTransaction through messenger #8408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94ee29a
Expose `KeyringController:signTransaction` through messenger
Mrtenz Apr 8, 2026
497b413
Update changelog
Mrtenz Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/keyring-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Expose `KeyringController:signTransaction` method through `KeyringController` messenger ([#8408](https://github.com/MetaMask/core/pull/8408))

### Changed

- Bump `@metamask/messenger` from `^1.0.0` to `^1.1.1` ([#8364](https://github.com/MetaMask/core/pull/8364), [#8373](https://github.com/MetaMask/core/pull/8373))
Expand Down
14 changes: 14 additions & 0 deletions packages/keyring-controller/src/KeyringController-method-action-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,19 @@ export type KeyringControllerSignTypedMessageAction = {
handler: KeyringController['signTypedMessage'];
};

/**
* Signs a transaction by calling down into a specific keyring.
*
* @param transaction - Transaction object to sign. Must be a `ethereumjs-tx` transaction instance.
* @param from - Address to sign from, should be in keychain.
* @param opts - An optional options object.
* @returns Promise resolving to a signed transaction string.
*/
export type KeyringControllerSignTransactionAction = {
type: `KeyringController:signTransaction`;
handler: KeyringController['signTransaction'];
};

/**
* Convert a base transaction to a base UserOperation.
*
Expand Down Expand Up @@ -316,6 +329,7 @@ export type KeyringControllerMethodActions =
| KeyringControllerSignEip7702AuthorizationAction
| KeyringControllerSignPersonalMessageAction
| KeyringControllerSignTypedMessageAction
| KeyringControllerSignTransactionAction
| KeyringControllerPrepareUserOperationAction
| KeyringControllerPatchUserOperationAction
| KeyringControllerSignUserOperationAction
Expand Down
1 change: 1 addition & 0 deletions packages/keyring-controller/src/KeyringController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ const MESSENGER_EXPOSED_METHODS = [
'signMessage',
'signEip7702Authorization',
'signPersonalMessage',
'signTransaction',
'signTypedMessage',
'decryptMessage',
'getEncryptionPublicKey',
Expand Down
1 change: 1 addition & 0 deletions packages/keyring-controller/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export type {
KeyringControllerSignMessageAction,
KeyringControllerSignEip7702AuthorizationAction,
KeyringControllerSignPersonalMessageAction,
KeyringControllerSignTransactionAction,
KeyringControllerSignTypedMessageAction,
KeyringControllerPrepareUserOperationAction,
KeyringControllerPatchUserOperationAction,
Expand Down
Loading