feat: Add new metadata properties to Web3Auth controllers#6504
Conversation
0957aef to
17317a4
Compare
matthiasgeihs
left a comment
There was a problem hiding this comment.
Thanks for creating the PR.
Note that several values need to be changed. In particular, access tokens should not be part of the state log.
Sorry, that was wrong. I misread the code and thought it would conditionally include the values, depending on whether they are present or not. Now I understand that |
matthiasgeihs
left a comment
There was a problem hiding this comment.
Sorry, can you please revert some of my requested changes. There was a misunderstanding on my end. See #6504 (comment).
There was a problem hiding this comment.
I had to be more creative here as the controller sometimes sets this key to an empty array
…Controller`" This reverts commit f8b67c448c2d064e03e61b53474b1a23c56cb18e.
9c7ff4f to
e66248b
Compare
Explanation
The new metadata properties
includeInStateLogsandusedInUihave been added to all controllers maintained by the Web3Auth team.References
includeInStateLogsandusedInUicontroller metadata properties #6443Checklist