Replace providerConfig setter with a public initializeProvider method#1133
Merged
Conversation
cryptodev-2s
changed the title
mcmire
requested changes
Mar 16, 2023
jskelly84
previously approved these changes
Mar 17, 2023
mcmire
reviewed
Mar 20, 2023
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
One more comment but otherwise looks good to me!
Gudahtt
reviewed
Mar 21, 2023
mcmire
previously approved these changes
Mar 30, 2023
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
One minor comment but looks good to me otherwise.
Member
|
Looks good to me too! I can approve after the conflicts are resolved |
cryptodev-2s
force-pushed
the
feature/remove-provider-setter
branch
from
257ec29 to
b70a5ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Replace providerConfig setter with a public initializeProvider method
Related issue #1021