fix: prevent nil dereference when VLESS listener initialization fails - #3195
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a nil pointer dereference in the VLESS listener when decryption is enabled and a later initialization step fails.
Cause
listener/sing_vless.Newuses named return values:If a later initialization step fails, such as certificate path validation or port binding, the function returns:
The named return value sl is set to nil before the deferred function runs. The deferred cleanup then dereferences
sl.decryption, causing:
This masks the original initialization error.
Fix
Capture the decryption pointer in a local variable before registering the deferred cleanup:
This ensures that the decryption instance is closed safely and that the original initialization error is returned to the
caller.
Expected Behavior
For example, when the certificate path is not included in the allowed paths, Mihomo should return the original error:
parse certificate failed, maybe format error:
tls: failed to find any PEM data in certificate input,
or path error: path is not subpath of home directory or SAFE_PATHS
It should not panic with a nil pointer dereference.