557 contained subroutines are not external#558
Merged
Matthew Hambley (MatthewHambley) merged 2 commits intomainfrom Apr 29, 2026
Merged
557 contained subroutines are not external#558Matthew Hambley (MatthewHambley) merged 2 commits intomainfrom
Matthew Hambley (MatthewHambley) merged 2 commits intomainfrom
Conversation
Joerg Henrichs (hiker)
requested review from
a team and
Matthew Hambley (MatthewHambley)
and removed request for
a team
This was referenced Apr 23, 2026
Joerg Henrichs (hiker)
added
the
Ready for review
Matthew Hambley (MatthewHambley)
approved these changes
Apr 29, 2026
Collaborator
Matthew Hambley (MatthewHambley)
left a comment
Matthew Hambley (MatthewHambley)
left a comment
There was a problem hiding this comment.
As advertised, a straight forward change.
Matthew Hambley (MatthewHambley)
deleted the
557_contained_subroutines_are_not_external
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents subroutines/functions that are 'contained' in another subroutine to be exported as defined external symbols. This is a requirement for Socrates, which has dozen of subroutines which each define their own
subroutine nf(...), which atm results in Fab complaining about duplicated symbols.We already exclude subroutines in modules and interfaces, so it is just a small change to also exclude anything that's an
Internal_Subprogram_Part(i.e. it iscontainedin another program unit).I also did some cleanup of pylint errors in a test file.