WIP - Number to words localisation improvements#149
Merged
Conversation
Move English, Arabic and Farsi converters to a separate strategies.
…ic fields to reduce allocations.
This was referenced Apr 9, 2014
Contributor
Author
|
Related to #132 |
Contributor
|
RE: Unsupported languages - Throwing an error would just upset people using it, at least the number would still have usable code. |
Contributor
Author
|
Yep, I do not like exceptions here as well |
…resentation of a number
Collaborator
There was a problem hiding this comment.
Awesome. I think we'll need to structure the Localisation folder a bit better; but good for now.
Collaborator
This was referenced Apr 10, 2014
ToQuantity / Ordinalize / ToOrdinalWords / ToWords should do nothing for unsupported languages.
#132
Closed
Closed
Collaborator
|
Thanks for your great contribution @hazzik. This is now released to NuGet as v1.19.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to improve experience and encourage users to localise ToWords/ToOrdinalWords extension methods.
I've introduced
INumberToWordsConverter:Also I want to clarify how shall behave untranslated converter? Shall it throw
NotSupportedExceptionor just returnnumber.ToString()?