pt-BR ToWords added#152
Conversation
|
Thanks a lot for this. As mentioned in #15 this needs to be changed to use the new approach implemented in #149. I think this pulls the rug under your feet; so you might actually have to close this one, pull the latest and add your code based on the new approach. Please also add your PR to the release notes file. |
|
I'll be doing the new implementation in a different branch later today. |
|
Sorry for this. Thanks :) |
|
I don't know the specific in pt-BR, but "pt-PT", |
|
I think we'll have to differentiate pt-PT from pt-BR. I was wondering if there were any differences. |
|
http://www.languagesandnumbers.com/como-contar-em-portugues-europeu/pt/por-prt/ btw, I was looking at the code and found out that I'll open a ticket for this, since it's another matter |
|
Yes @kappy, I noticed that problem yesterday. But I thought there were no differences in counting, so I just implemented it as it would work for both. Clearly we'll have to treat them differently. I'll be back home in 8 hours, we could discuss a way to treat that. |
This doesn't support gender differences for portuguese language, but handles all the others cases described here