Repository navigation
[pull] trunk from WordPress:trunk - #558
Merged
Merged
Conversation
* Sync connectors PHP behavior with core backport * Add missing Gutenberg text domain in connectors strings Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: dlind1
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
* Unify block settings dropdown menu items across list views Add missing menu items to both list view implementations so they have feature parity. Navigation block's LeafMoreMenu now includes Duplicate, Add before, and Add after. BlockSettingsDropdown used by other blocks in contentOnly list view now includes Move up and Move down. This is a prerequisite for the larger refactoring in #75694. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * add options to leaf more menu * Update zoom-out e2e test to account for Move up/Move down menu items Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Scope Move up/Move down to contentOnly mode only Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Add icon, disabled, and accessibleWhenDisabled to Move up/Move down Disable Move up when the block is first in its parent, and Move down when it is last. Add chevron icons and accessibleWhenDisabled to both BlockSettingsDropdown and LeafMoreMenu, matching the approach in #75694. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix Move up/Move down visibility by checking parent's editing mode The blocks shown in the contentOnly list view are children of the contentOnly block. Their own editing mode is not contentOnly, so the check needs to look at the parent block's editing mode instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Pass isContentOnlyListView prop from list view context Instead of trying to infer contentOnly context from the parent block's editing mode (which also matches in the main list view), explicitly pass isContentOnlyListView from the list view block component where the root client ID and its editing mode are known. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…75971) Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: Mustafabharmal <mustafabharmal@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: joedolson <joedolson@git.wordpress.org>
…ic construction (#75905) * ESLint: Broaden no-unknown-ds-tokens to all strings and catch dynamic construction * Add changelog * Add eslint-disable comments for lint tooling and test files * Disable no-unknown-ds-tokens for eslint-plugin and theme packages * Fix regex to also match tokens at start of string * Add word-boundary valid test case * Fix false-positive dynamic token detection in mixed template literals Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
The homeUrl is the location of the front end site, so it should be used instead of the siteUrl. This follows the implementation by the home-link block. --------- Co-authored-by: jeryj <jeryj@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org>
… View (#75607) * Initial plan * Use navigation menu name in block display information Co-authored-by: scruffian <275961+scruffian@users.noreply.github.com> * Consolidate navigation check into syncedTitle condition Co-authored-by: scruffian <275961+scruffian@users.noreply.github.com> * Rename syncedTitle to customTitle for clarity Co-authored-by: scruffian <275961+scruffian@users.noreply.github.com> * Use blockInformation.title in Content tab block quick navigation Co-authored-by: scruffian <275961+scruffian@users.noreply.github.com> * Use custom menu name in List View tab header for contentOnly mode Co-authored-by: scruffian <275961+scruffian@users.noreply.github.com> * Refactor: Extract shouldUseBlockLabel variable for clarity Co-authored-by: scruffian <275961+scruffian@users.noreply.github.com> * Add E2E test for custom navigation menu names display Co-authored-by: scruffian <275961+scruffian@users.noreply.github.com> * Use getBlockLabel for all blocks to display custom labels in Content tab Co-authored-by: scruffian <275961+scruffian@users.noreply.github.com> * Fix block label to use getBlockLabel for custom names in canvas Use getBlockLabel in block.js to display custom block labels (like navigation menu names) in the editor canvas. This ensures that navigation blocks with custom menu names show 'Block: Header Menu' instead of 'Block: Navigation' in their accessible name. Fixes E2E test failure where test expects to find blocks by their custom menu names. * Block Editor: Display custom block labels in Block Inspector and List View Blocks with custom labels (via __experimentalLabel) were not consistently displayed throughout the UI. Navigation blocks inside patterns displayed the generic "Navigation" title instead of their custom menu names (e.g., "Header Menu", "Footer Menu"), making it difficult to distinguish between multiple navigation blocks. **Changes:** 1. useBlockDisplayInformation: Call getBlockLabel for ALL blocks (not just synced) to retrieve custom labels from any block with __experimentalLabel defined. 2. BlockQuickNavigation: Use blockInformation?.title instead of blockType?.title to display custom labels in the Content tab. 3. MenuInspectorControls: Use blockTitle variable instead of hardcoded "Navigation" string for the List View tab header in contentOnly mode. 4. Added E2E test: "displays custom menu name in List View tab header" to verify navigation blocks with different custom menu names display correctly. All blocks with custom labels now display them consistently in the Block Inspector Content tab, List View tab header, and elsewhere throughout the UI. Fixes #75348 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * Update navigation-editor test to expect custom menu name The PanelBody title in contentOnly mode now shows the custom menu name instead of the hardcoded "Navigation" string. Update the test assertion to expect "Primary Menu" which matches the menu created in the test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix navigation-editor test strict mode violation Scope the heading assertion to `.components-panel__body-title` to distinguish the PanelBody title heading from the BlockCard heading, both of which now show the custom menu name "Primary Menu". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix navigation-editor test: use .first() for duplicate headings Both the BlockCard and the navigation list view panel now show the custom menu name "Primary Menu" (since useBlockDisplayInformation calls getBlockLabel for all blocks). Use .first() to match either heading and avoid the strict mode violation. The previous fix incorrectly scoped to .components-panel__body-title which doesn't exist in this context (the navigation editor uses the non-contentOnly rendering path with a Heading component, not a collapsible PanelBody). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove BlockCard title change, use useBlockDisplayTitle in Content tab Revert useBlockDisplayInformation to only call getBlockLabel for synced blocks (as on trunk). This keeps the Block Inspector header (BlockCard) showing the generic block type name ("Navigation") rather than the custom menu name, avoiding confusion about what type of block it is. Instead, have BlockQuickNavigation use useBlockDisplayTitle directly to get the custom menu name for the Content tab. This is more targeted: only the Content tab and List View tab header show custom names. Revert navigation-editor test back to checking for "Navigation" heading since BlockCard now shows the block type name again. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix blockTitle is not defined after rebase The rebase onto trunk picked up a refactor that moved useBlockDisplayTitle into NavigationListViewHeader, but the contentOnly PanelBody path still referenced blockTitle. Add useBlockDisplayTitle back to MenuInspectorControls for the contentOnly mode PanelBody title. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix prettier formatting for useBlockDisplayTitle call Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Update E2E test to verify contentOnly mode behavior The previous test checked navigation blocks in a regular post, which tested pre-existing behavior (NavigationListViewHeader already uses useBlockDisplayTitle on trunk). The PR's actual change is the PanelBody title in contentOnly mode. Updated the test to wrap the navigation block in a contentOnly-locked group (templateLock: "contentOnly"), which triggers isSelectionWithinCurrentSection and exercises the changed code path. The test now asserts on the collapsible PanelBody button title. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: scruffian <275961+scruffian@users.noreply.github.com> Co-authored-by: Ben Dwyer <ben@scruffian.com> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: mecskyverse <aakashverma1@git.wordpress.org> Co-authored-by: allilevine <firewatch@git.wordpress.org>
* UI: Add Notice component * Add CHANGELOG note for new Notice component * Fix getByRole missing aria-hidden images * Expand code comments in Notice implementation
* Playlist Block: Add WaveformPlayer visualization Replace the browser's native audio controls with an interactive waveform visualization using @arraypress/waveform-player library. This provides: - Consistent waveform visualization across all browsers - Visual progress indication during playback - Interactive seeking by clicking on the waveform - Keyboard accessibility (arrow keys for seeking) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * share more code * remove player header * update comment * remove unneeded function exposure Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * remove try catch * inline the current track component * move options into configs and add i18n * make the heigt configurable * remove extra defensive coding for the fallback * fix autoplay * fix the editor * Remove player header * fix the current track display in the editor * add duration in editor * remove border from the play button * update comment * remove the refs and just reinit whenever the tracklisting changes * remove _x since we have to provide a translators comment anyway * Replace useEffect and setTimeout with useRefEffect * simplify rendering * remove waveformInstanceRef * remove custom events * add a comment to explain the problems with destroy() * change the setTimeout to listen for waveformplayer:ready * add error logging * remove double encoding * update to locked version * Fix playlist waveform player edge cases and cleanup - Use ownerDocument.defaultView.getComputedStyle for iframe compatibility - Fix memory leak: clean up handleReady listener on destroy - Fix race condition: verify track is still current after delay - Add error handling for auto-advance play() - Move styleSvgIcons to ready event when icons exist - Remove unused bgColor from getWaveformColors - Remove inappropriate esc_html() for JSON context (fixes ') - Update @arraypress/waveform-player to ^1.2.0 * remove the gap between the button and the player * extract aria label to function * more more code to separate functions * remove duplicate styles from editor.scss * move play button accessibility changes to a separate function * add tests for the extracted functions * move the waveform component to utils for better separation of concerns * Refactor to use the same function in the editor and frontend * add more tests * simplify view.js by moving more things to utils * remove next track delay as we dont need it * remove dead code * remove more dead code * update to the latest version of the library * simplify autoplay * fix resizing in the editor * fix styling in the editor * remove unneeded styles * use @use * add tests for the PHP render * add jsdom to tests * tidy up styles * set text color via JS Pass text colors to the waveform library via data attributes instead of overriding inline styles with !important in CSS. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix PHPCS * fix tests * fix PHPCS * rename test * strip tags from the ariaLabel * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * refactor test to share the basePlayerData * remove redundant test * update test description * try using the import * import the CSS into the style.scss file * remove the container when we destroy it * Consolidate optional attribute tests in waveform-utils Combine three separate tests for optional attributes (title, artist, artwork) into a single test that verifies all optional attributes are set when provided. This reduces redundancy while maintaining coverage. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Simplify waveform player accessibility with hardcoded label Remove the ariaLabel parameter from setupPlayButtonAccessibility and initWaveformPlayer, replacing it with a hardcoded "Play" label. This simplifies the API while maintaining keyboard seeking functionality (ArrowLeft/Right navigation). The keyboard seeking feature is preserved as it provides valuable accessibility for navigating through audio content. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * no need to set role button on a button * add this fix for now * remove seeking * pass labels from the server * use loadTrack instead of destroy * remove change * Fix unhandled promise rejection and stale URL cache on loadTrack failure Add .catch(logPlayError) to the loadTrack() promise chain and move the URL cache update inside .then() so it only persists on success. This prevents unhandled rejections on network errors and allows the user to retry loading the same track. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Sanitize track metadata with wp_strip_all_tags() to prevent XSS The third-party waveform-player library uses innerHTML for the subtitle field in its createDOM() method. Use wp_strip_all_tags() instead of raw values to prevent HTML injection, without double-encoding in the JSON context of wp_interactivity_state(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * explain why we have an AbortError * Remove scale(1.05) hover effect from waveform player button Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Update packages/block-library/src/playlist/index.php Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * Apply suggestions from code review --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: harshbhonsle <harshbhonsle08@git.wordpress.org>
…6015) When determining whether a navigation link is internal or external, the previous implementation compared URLs by their origin (scheme + host + port). This caused links using http:// to be incorrectly classified as external when the site URL used https://, even if they pointed to the same domain. ------------------- Co-authored-by: jeryj <jeryj@git.wordpress.org> Co-authored-by: mikachan <mikachan@git.wordpress.org>
…6006) Bumps the github-actions group with 1 update in the /.github/setup-node directory: [actions/upload-artifact](https://github.com/actions/upload-artifact). Bumps the github-actions group with 3 updates in the /.github/workflows directory: [actions/upload-artifact](https://github.com/actions/upload-artifact), [actions/checkout](https://github.com/actions/checkout) and [actions/download-artifact](https://github.com/actions/download-artifact). Updates `actions/upload-artifact` from 6.0.0 to 7.0.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@b7c566a...bbbca2d) Updates `actions/upload-artifact` from 5.0.0 to 7.0.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@b7c566a...bbbca2d) Updates `actions/checkout` from 6.0.1 to 6.0.2 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v6.0.1...de0fac2) Updates `actions/download-artifact` from 6.0.0 to 8.0.0 - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v6...70fc10c) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/upload-artifact dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/checkout dependency-version: 6.0.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: actions/download-artifact dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: desrosj <desrosj@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )