Skip to content

[pull] trunk from WordPress:trunk - #16

Merged
pull[bot] merged 3 commits into
MaxMood96:trunkfrom
WordPress:trunk
Aug 27, 2021
Merged

pull[bot] merged 3 commits into
MaxMood96:trunkfrom
WordPress:trunk

Conversation

@pull

@pull pull Bot commented Aug 27, 2021 •

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

ramonjd and others added 3 commits August 27, 2021 19:23
* Adding context to 'none' strings, and also implementing suggestions from #22095
This is because "None" can be translated differently in languages other than English depending on the context.

* As always, my linter was asleep
Check if block color support have been explicitly opted out

BackgroundColor and color are opt-out block supports: they're enabled if there's support for any color unless the block opts-out from them explicitly. Global styles UI panels were't respecting this opt out process, which is why we add logic to validate whether or not a block has turned off background color and color supports.
* Fix missing class renames.

* Add readme notes.

* Fix flex issue.
@pull pull Bot added the ⤵️ pull label Aug 27, 2021
@pull
pull Bot merged commit 662dabc into MaxMood96:trunk Aug 27, 2021
pull Bot pushed a commit that referenced this pull request Jan 24, 2026
* New, reworked structure and editing

* Refactoring the entire tabs experience, rough right now, should have this cleaned up by end of week.

* Greater granular flex styling, need to go back in and cleanup old styles

* Full border styles for menu items

* Style tweaks

* Enhance tab functionality by updating the AddTabToolbarControl to manage tabs-menu selection and active tab index. Implement auto-edit mode for newly added tabs in the TabsMenu edit component.

* Allow renaming of tab blocks, leaving note in deprecation upgrade to remove later

* Style and dev cleanup

* Default layouts for tabs-menu and keyboard handling

* Tweaks

* PHPCS cleanup

* Dimensions block.json supports, correct format

* Adding shadow support

* Cleanup

* Increased performance, move client side and server side tabs list generation all into context.

* Cleanup

* Cleanup on styles and blockgap

* Lets back off on blockspacing for tabs-menu for now

* Introduce new core/tabs-menu-item block (#14)

* New block/core tabs menu item (#16)

* Introducing new core/tabs-menu-item block, utilizes blockcontextprovider hack we use for templating blocks. *May rename the block to tabs-menu-item-template

* Trying to get this working as I'd like

* Introducing core/tabs-menu-item, a templating block for styling the interior element of tabs-menu

* Style cleanup

* Block cleanup for MVP

* Add text align to tabs-menu-item

* Now tabs-menu interior items can be styled using dimensions controls in tabs-menu

* Cleanup

* Remove refactor artifact

* Cleanup and initializing new tab with a proper label

* Tab removal button

- Add "Remove Tab" toolbar button to tabs block
- Code cleanup

* Clearer labels on block toolbar buttons

* Cleaning up tabs id, utilizing anchor instead of a custom attribute, injecting tabs id dynamically if none present early in core/tabs context.

* new add tab controls per some internal prc user testing with editors

* Leaving the add tab in place in tabs-menu-item, pulling from tabs-menu extra appender... for now

* Cleanup, align with labels like core/accordion

* Move add and remove tab into segmented block toolbar group

* Sensible defaults for border on tabs-menu

* Resolve phpcs issue

* Cleanup on style

* Introduce custom controls for moving tab

* remove unused tabs styles, get rid of opacity on styles, simplify styles further, enhance block example.

* Cleanup on block mover

* Resolve some oustanding linting issues

* Linting error resolution

* Resolving scss linting issue

* Update core blocks documentation to reflect changes in supported features for tabs and tab panels, including color and typography attributes. Hoping this resolves final PR checks.

Co-authored-by: sethrubenstein <smrubenstein@git.wordpress.org>
Co-authored-by: mikachan <mikachan@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants