Repository navigation
release: v7.0.5 - #73
Conversation
- auto-update: install releases after 15 min on npm (was 24h) - auto-update: pick the newest eligible release instead of stalling on a bad or engine-incompatible 'latest' - fix: move @vscode/ripgrep to regular dependencies (completes 7.0.3) - docs: update README/RELEASE.md age window
There was a problem hiding this comment.
🧪 PR Review is completed: The auto-update refactor (fetchEligibleReleases + fallback to the newest compatible, non-bad release) is correct — staging, rollback, skip and thrash scenarios all check out. One flag: MIN_RELEASE_AGE_MS drops the safety window from 24h to 15min, contradicting RELEASE.md's documented bad-release containment strategy. package.json (version bump + dependency reordering): no issues.
Skipped files
CHANGELOG.md: Skipped file patternREADME.md: Skipped file patternRELEASE.md: Skipped file patternpackage-lock.json: Skipped file pattern
⬇️ Low Priority Suggestions (1)
src/utils/autoUpdate.ts (1 suggestion)
Location:
src/utils/autoUpdate.ts(Lines 23-23)🟡 Release-Safety / Business Logic
Issue:
MIN_RELEASE_AGE_MSis cut from 24h (24 * 60 * 60 * 1_000) to 15 minutes, but RELEASE.md still documents the invariant: "Releases auto-install only after 24h on npm, so ship a fix within a day to keep a bad release from spreading." With a 15-minute window, a release that passes--self-testyet misbehaves in real usage reaches auto-updating users almost immediately, and the doc comment above the constant ("so a bad release can be caught ... before it reaches everyone") no longer reflects the real buffer.Fix: If the shorter window is intentional (leaning on verify + launcher rollback instead of the age buffer), update RELEASE.md's "Background updates — compatibility rules" section and add a 7.0.5 CHANGELOG entry documenting the new behavior in this same release; if it was not meant to ship, restore the 24h value.
Impact: Keeps the documented release process truthful and preserves the stated bad-release containment window for the team operating the releases.
- export const MIN_RELEASE_AGE_MS = 15 * 60 * 1_000; +
Release v7.0.5
Bumps
@matterailab/orbcodeto7.0.5. After merge, tag the merge commit onmainand push the tag to trigger the publish workflow:git checkout main && git pull git tag v7.0.5 git push origin v7.0.5Changed
MIN_RELEASE_AGE_MS).Fixed
latestrelease: it now scans all non-deprecated, non-prerelease releases newer than the running version past the age window and stages the newest one this Node can run, newer than what's staged, and not previously failed (isBadVersion).@vscode/ripgrepmoved to regular dependencies (completes the 7.0.3 fix — installs that skip optional deps no longer miss the bundledrg).Docs
Checklist
npm run typecheckpassesnpm run buildpasses;node dist/index.js --version→7.0.5