Create map-link.disabled for templated, stylesheet link control API#1019
Merged
prushforth merged 1 commit intoMaps4HTML:mainfrom Dec 12, 2024
Merged
Create map-link.disabled for templated, stylesheet link control API#1019prushforth merged 1 commit intoMaps4HTML:mainfrom
prushforth merged 1 commit intoMaps4HTML:mainfrom
Conversation
prushforth
force-pushed
the
link-disabled
branch
2 times, most recently
from
cbd611f to
bdd54ae
Compare
- Rename map-link._validateDisabled() to map-link.isVisible()
- Add short circuit check for this.disabled in map-link.isVisible
- Add map-link.disabled as criteria for whenReady() to resolve for rel=
tile,image,features,query.
- Add await to call to _createTemplatedLink which was missing, possibly
causing lack of rendering when invoking map-link.enable().
- Do map-link.getLayerEl()._validateDisabled() after enable/disable of
link - updates layer control if applicable
- Refactor connectedCallback to consolidate stylesheet code into
_createStylesheetLink method. Update whenReady criteria for both types
of stylesheet link.
- Ensure that protomaps stylesheet link selected by templated link is not
prior disabled
- Add tests for map-link.disabled for rel=tile,image,features,query
- Update layer so that disabled query links aren't queryable
- Add css, class values for test restaurants
- Add waitForTimeout(500) to de-flake the tests
- fixed test i headful mode
- Update map-extent to ignore disabled links for bounds calculations
- Update tests to include logic for initially-disabled templated link
- Replace waitForTimeout(500) with { sloMo: 500 }
prushforth
force-pushed
the
link-disabled
branch
from
ef673f9 to
a934e88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1020
Co-authored by @yushan-mu