Change structure of pmtilesRules, allow icon sheet, require returned promise.#1015
Merged
prushforth merged 2 commits intoMaps4HTML:mainfrom Nov 15, 2024
Merged
Conversation
prushforth
force-pushed
the
pmtiles-icon-sheet
branch
from
79fa22a to
5f6bf66
Compare
Remove grunt-rollup grunt plugin, replace with customRollup task, config done via external rollup.config.js. Remove uglify grunt plugin, replace with terser rollup plugin (does a better job with source maps and chained minification) Add nrcan-basemap grunt task for sibling project to get nrcan vector tile basemap working with pmtiles. Change the required structure of pmtilesRules.js - requires a sheet that gets loaded via sheet.load(), after which all the style rules are set and returned. This allows style label rules to use IconSymbolizers, however it requires a slightly awkward structure to be imposed on a pmtiles stylesheet module. See pmtilesRules.js, and corresponding test stylesheet modules for more info. Add await on loading the pmtilesRules.js stylesheet module Add script 'test-serve' to package.json to run the test web server to debug test HTML pages as required, removing the need to drop into a console Update pmtiles test that was not testing rendering, only a blank map canvas. Add test mvt tiles to validate that protomapsL is available to stylesheet modules upon import. Add test for custom styled mvt data, with win32 capture only Restructure test style modules to conform to new promise-returning expected structure Adjuust timeout limit on map-link whenReady() Conditionally await on map-link.whenReady() for stylesheet module associated to pmtiles / mvt layer (if omitted, don't want exceptions, prefer to reject in whenReady(), although it's slow. Add linux image for custom styles. Loosen pixel comparison to 200 pixels
Remove postinstall --with-deps so that npm install does not require root privilege
prushforth
force-pushed
the
pmtiles-icon-sheet
branch
from
5f6bf66 to
25e6448
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1011