feat: add dbus and remove xkbcommon - #21
Open
litwak913 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
嗨,我留下了一些整体性的反馈:
- 在
file(REMOVE_RECURSE ...)代码块中,"${CURRENT_PACKAGES_DIR}/share/dbus-1/system.conf"出现了两次;为提高可读性,建议去掉重复的条目。 - 在发布配置中,你目前设置的是
DBUS_DISABLE_ASSERT=OFF;如果这是刻意为之,那没有问题,但否则建议在发布构建中启用断言禁用,以符合常见的性能预期。
给 AI 代理的提示
请根据本次代码审查中的评论进行修改:
## 整体评论
- 在 `file(REMOVE_RECURSE ...)` 代码块中,`"${CURRENT_PACKAGES_DIR}/share/dbus-1/system.conf"` 出现了两次;为提高可读性,建议去掉重复的条目。
- 在发布配置中,你目前设置的是 `DBUS_DISABLE_ASSERT=OFF`;如果这是刻意为之,那没有问题,但否则建议在发布构建中启用断言禁用,以符合常见的性能预期。帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English
Hey - I've left some high level feedback:
- In the
file(REMOVE_RECURSE ...)block,"${CURRENT_PACKAGES_DIR}/share/dbus-1/system.conf"appears twice; consider removing the duplicate entry for clarity. - For the release configuration, you currently set
DBUS_DISABLE_ASSERT=OFF; if this is intentional it's fine, but otherwise consider enabling assertion disabling in release builds to match typical performance expectations.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the `file(REMOVE_RECURSE ...)` block, `"${CURRENT_PACKAGES_DIR}/share/dbus-1/system.conf"` appears twice; consider removing the duplicate entry for clarity.
- For the release configuration, you currently set `DBUS_DISABLE_ASSERT=OFF`; if this is intentional it's fine, but otherwise consider enabling assertion disabling in release builds to match typical performance expectations.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
增加了 DBus 构建,从最新的 vcpkg 上拉了些补丁,同时移除暂时没用的 xkbcommon
Summary by Sourcery
新特性:
Original summary in English
Summary by Sourcery
New Features: