Skip to content

feat: add dbus and remove xkbcommon - #21

Open
litwak913 wants to merge 1 commit into
MaaXYZ:masterfrom
litwak913:master
Open

feat: add dbus and remove xkbcommon#21
litwak913 wants to merge 1 commit into
MaaXYZ:masterfrom
litwak913:master

Conversation

@litwak913

@litwak913 litwak913 commented Aug 16, 2026

Copy link
Copy Markdown

增加了 DBus 构建,从最新的 vcpkg 上拉了些补丁,同时移除暂时没用的 xkbcommon

Summary by Sourcery

新特性:

  • 通过 vcpkg overlay 引入 DBus 端口,包括对可选的 systemd 和 X11 功能及相关工具的支持。
Original summary in English

Summary by Sourcery

New Features:

  • Introduce a DBus port via vcpkg overlay, including support for optional systemd and X11 features and associated tools.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗨,我留下了一些整体性的反馈:

  • file(REMOVE_RECURSE ...) 代码块中,"${CURRENT_PACKAGES_DIR}/share/dbus-1/system.conf" 出现了两次;为提高可读性,建议去掉重复的条目。
  • 在发布配置中,你目前设置的是 DBUS_DISABLE_ASSERT=OFF;如果这是刻意为之,那没有问题,但否则建议在发布构建中启用断言禁用,以符合常见的性能预期。
给 AI 代理的提示
请根据本次代码审查中的评论进行修改:

## 整体评论
-`file(REMOVE_RECURSE ...)` 代码块中,`"${CURRENT_PACKAGES_DIR}/share/dbus-1/system.conf"` 出现了两次;为提高可读性,建议去掉重复的条目。
- 在发布配置中,你目前设置的是 `DBUS_DISABLE_ASSERT=OFF`;如果这是刻意为之,那没有问题,但否则建议在发布构建中启用断言禁用,以符合常见的性能预期。

Sourcery 对开源项目是免费的——如果你觉得我们的评审有帮助,欢迎分享 ✨
帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English

Hey - I've left some high level feedback:

  • In the file(REMOVE_RECURSE ...) block, "${CURRENT_PACKAGES_DIR}/share/dbus-1/system.conf" appears twice; consider removing the duplicate entry for clarity.
  • For the release configuration, you currently set DBUS_DISABLE_ASSERT=OFF; if this is intentional it's fine, but otherwise consider enabling assertion disabling in release builds to match typical performance expectations.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In the `file(REMOVE_RECURSE ...)` block, `"${CURRENT_PACKAGES_DIR}/share/dbus-1/system.conf"` appears twice; consider removing the duplicate entry for clarity.
- For the release configuration, you currently set `DBUS_DISABLE_ASSERT=OFF`; if this is intentional it's fine, but otherwise consider enabling assertion disabling in release builds to match typical performance expectations.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@litwak913 litwak913 changed the title feat: add dbus feat: add dbus and remove xkbcommon Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant