Skip to content

Fix tuo mako file to support cpu build and batch scripts.#1362

Merged
sbryngelson merged 1 commit intoMFlowCode:masterfrom
jaguilar37:feature/fix-tuo-mako
Apr 9, 2026
Merged

Fix tuo mako file to support cpu build and batch scripts.#1362
sbryngelson merged 1 commit intoMFlowCode:masterfrom
jaguilar37:feature/fix-tuo-mako

Conversation

@jaguilar37
Copy link
Copy Markdown
Contributor

@jaguilar37 jaguilar37 commented Apr 9, 2026

Switched "gpu" to "gpu_enabled" so that the batch script is properly made when running on CPU and GPU. With just "gpu", it defaults to always being gpu.

Description

When running/building MFC for CPU on Tuolumne, the mako file defaults to GPU everytime. I switched the check to "gpu_enabled" based on the format used in other mako files. This produces the correct behavior.

Type of change

  • Bug fix

Testing

I compiled and ran both CPU and GPU jobs with this change.

Switched "gpu" to "gpu_enabled" so that the batch script is properly made when running on CPU and GPU. With just "gpu", it defaults to always being gpu.
@jaguilar37 jaguilar37 marked this pull request as ready for review April 9, 2026 18:42
@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review bot commented Apr 9, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

1 similar comment
@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review bot commented Apr 9, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 76d8051d-25a0-47ed-8ba0-08dbc47d7db5

📥 Commits

Reviewing files that changed from the base of the PR and between f6f5c85 and 3179be7.

📒 Files selected for processing (1)
  • toolchain/templates/tuo.mako

📝 Walkthrough

Walkthrough

The template file toolchain/templates/tuo.mako has been updated to standardize GPU configuration checks throughout. All references to the gpu variable have been replaced with gpu_enabled to determine GPU-related behavior. This affects three points: the mfc.sh module load flag selection, the MPICH_GPU_SUPPORT_ENABLED environment variable export condition, and the inclusion of GPU task arguments in MPI execution through flux run.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing the tuo mako file to support CPU builds and batch scripts by correcting the GPU-related logic.
Description check ✅ Passed The description covers the essential information: bug fix classification, motivation (gpu vs gpu_enabled check), rationale (other mako files use gpu_enabled), and testing performed (CPU and GPU jobs tested).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sbryngelson sbryngelson merged commit a6ac2a3 into MFlowCode:master Apr 9, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants