ci: skip pre-commit hook on automated cache commit#1320
ci: skip pre-commit hook on automated cache commit#1320sbryngelson merged 1 commit intoMFlowCode:masterfrom
Conversation
Claude Code ReviewHead SHA: 048439c Files changed:
Summary:
Findings:
|
There was a problem hiding this comment.
Pull request overview
Updates the CI workflow that regenerates and commits the gcov coverage cache so that the automated commit step does not run local git hooks (e.g., the repo’s auto-installed pre-commit hook), improving reliability of the cache-push automation.
Changes:
- Add
--no-verifyto the workflow’sgit commitcommand when committing the regenerated coverage cache tomaster.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request modifies 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can suggest fixes for GitHub Check annotations.Configure the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1320 +/- ##
==========================================
- Coverage 45.12% 45.01% -0.11%
==========================================
Files 70 70
Lines 20554 20562 +8
Branches 1962 1962
==========================================
- Hits 9274 9255 -19
- Misses 10152 10179 +27
Partials 1128 1128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
rebuild-cacheCI job'sgit committriggers the pre-commit hook, which runsprecheckon the entire repo. If any other merged PR introduced a spelling/lint issue, the automated cache commit fails — even though onlytest_coverage_cache.json.gzis being committed.--no-verifyto the automatedgit commitin the "Commit Cache to Master" step.Fixes the failure in https://github.com/MFlowCode/MFC/actions/runs/23218089807/job/67484083040
Test plan
rebuild-cachejob succeeds on the next push to master🤖 Generated with Claude Code